Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phonetics for 紮 #575

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix phonetics for 紮 #575

merged 1 commit into from
Feb 2, 2025

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Jan 31, 2025

The concise dictionary prefers 紮 ㄓㄚˊ.
Add both 紮 ㄓㄚˊ and 紮 ㄗㄚ for all phrases.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E7%B4%AE#searchL

Summary by Bito

Enhancement of BPMFMappings.txt with comprehensive Bopomofo notations for the Chinese character '纮' (zha) and its compound words. Added multiple phonetic variations including 'ㄓㄚˊ' and 'ㄗㄚ' for various phrases, aligned with concise dictionary preferences.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

The concise dictionary prefers `紮 ㄓㄚˊ`.
Add both `紮 ㄓㄚˊ` and `紮 ㄗㄚ` for all phrases.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E7%B4%AE#searchL
@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 14:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • Source/Data/BPMFMappings.txt: Language not supported
Copy link

bito-code-review bot commented Jan 31, 2025

Code Review Agent Run #02ea89

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 0616b24..0616b24
    • Source/Data/BPMFMappings.txt
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@xatier
Copy link
Contributor Author

xatier commented Jan 31, 2025

$ diff -y <(./find.py 紮 ㄓㄚˊ) <(./find.py 紮 ㄗㄚ)
三角巾包紮法 ㄙㄢ ㄐㄧㄠˇ ㄐㄧㄣ ㄅㄠ ㄓㄚˊ ㄈㄚˇ	      |	三角巾包紮法 ㄙㄢ ㄐㄧㄠˇ ㄐㄧㄣ ㄅㄠ ㄗㄚ ㄈㄚˇ
包紮 ㄅㄠ ㄓㄚˊ						      |	包紮 ㄅㄠ ㄗㄚ
包紮法 ㄅㄠ ㄓㄚˊ ㄈㄚˇ					      |	包紮法 ㄅㄠ ㄗㄚ ㄈㄚˇ
包紮著 ㄅㄠ ㄓㄚˊ ㄓㄜ˙					      |	包紮著 ㄅㄠ ㄗㄚ ㄓㄜ˙
屯紮 ㄊㄨㄣˊ ㄓㄚˊ					      |	屯紮 ㄊㄨㄣˊ ㄗㄚ
捆紮 ㄎㄨㄣˇ ㄓㄚˊ					      |	捆紮 ㄎㄨㄣˇ ㄗㄚ
穩紮穩打 ㄨㄣˇ ㄓㄚˊ ㄨㄣˇ ㄉㄚˇ			      |	穩紮穩打 ㄨㄣˇ ㄗㄚ ㄨㄣˇ ㄉㄚˇ
紮上 ㄓㄚˊ ㄕㄤˋ					      |	紮上 ㄗㄚ ㄕㄤˋ
紮上來 ㄓㄚˊ ㄕㄤˋ ㄌㄞˊ				      |	紮上來 ㄗㄚ ㄕㄤˋ ㄌㄞˊ
紮上去 ㄓㄚˊ ㄕㄤˋ ㄑㄩˋ				      |	紮上去 ㄗㄚ ㄕㄤˋ ㄑㄩˋ
紮下 ㄓㄚˊ ㄒㄧㄚˋ					      |	紮下 ㄗㄚ ㄒㄧㄚˋ
紮下來 ㄓㄚˊ ㄒㄧㄚˋ ㄌㄞˊ				      |	紮下來 ㄗㄚ ㄒㄧㄚˋ ㄌㄞˊ
紮下去 ㄓㄚˊ ㄒㄧㄚˋ ㄑㄩˋ				      |	紮下去 ㄗㄚ ㄒㄧㄚˋ ㄑㄩˋ
紮好 ㄓㄚˊ ㄏㄠˇ					      |	紮好 ㄗㄚ ㄏㄠˇ
紮實 ㄓㄚˊ ㄕˊ						      |	紮實 ㄗㄚ ㄕˊ
紮寨 ㄓㄚˊ ㄓㄞˋ					      |	紮寨 ㄗㄚ ㄓㄞˋ
紮帶子 ㄓㄚˊ ㄉㄞˋ ㄗ˙					      |	紮帶子 ㄗㄚ ㄉㄞˋ ㄗ˙
紮成 ㄓㄚˊ ㄔㄥˊ					      |	紮成 ㄗㄚ ㄔㄥˊ
紮營 ㄓㄚˊ ㄧㄥˊ					      |	紮營 ㄗㄚ ㄧㄥˊ
紮紮實實 ㄓㄚˊ ㄓㄚˊ ㄕˊ ㄕˊ				      |	紮紮實實 ㄗㄚ ㄗㄚ ㄕˊ ㄕˊ
紮緊 ㄓㄚˊ ㄐㄧㄣˇ					      |	紮緊 ㄗㄚ ㄐㄧㄣˇ
紮起 ㄓㄚˊ ㄑㄧˇ					      |	紮起 ㄗㄚ ㄑㄧˇ
紮起來 ㄓㄚˊ ㄑㄧˇ ㄌㄞˊ				      |	紮起來 ㄗㄚ ㄑㄧˇ ㄌㄞˊ
結紮 ㄐㄧㄝˊ ㄓㄚˊ					      |	結紮 ㄐㄧㄝˊ ㄗㄚ
綁紮 ㄅㄤˇ ㄓㄚˊ					      |	綁紮 ㄅㄤˇ ㄗㄚ
綑紮 ㄎㄨㄣˇ ㄓㄚˊ					      |	綑紮 ㄎㄨㄣˇ ㄗㄚ
駐紮 ㄓㄨˋ ㄓㄚˊ					      |	駐紮 ㄓㄨˋ ㄗㄚ
駐紮地 ㄓㄨˋ ㄓㄚˊ ㄉㄧˋ				      |	駐紮地 ㄓㄨˋ ㄗㄚ ㄉㄧˋ

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Enhanced Chinese Phonetic Mappings

BPMFMappings.txt - Added multiple phonetic mappings for '紮' (zha) and related compound words with Bopomofo notation

@lukhnos lukhnos merged commit ba933fa into openvanilla:master Feb 2, 2025
1 check passed
@xatier xatier deleted the zha branch February 2, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants