Fix phonetics for 括 #574
Open
Fix phonetics for 括 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`括約肌 ㄎㄨㄛˋ ㄩㄝ ㄐㄧ` is the only `括 ㄎㄨㄛˋ` from the concise dictionary. We have 包括 and 括弧 in our dictionary. ``` $ ./find.py 括 ㄎㄨㄛˋ 包括 ㄅㄠ ㄎㄨㄛˋ 括弧 ㄎㄨㄛˋ ㄏㄨˊ 括約肌 ㄎㄨㄛˋ ㄩㄝ ㄐㄧ ``` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8B%AC#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
Code Review Agent Run #82264cActionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
|
I'm not sure if we'd like to delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
括約肌 ㄎㄨㄛˋ ㄩㄝ ㄐㄧis the only括 ㄎㄨㄛˋfrom the concise dictionary.We have 包括 and 括弧 in our dictionary.
Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8B%AC#searchL
Summary by Bito
Added new phonetic mappings in BPMFMappings.txt for Chinese characters '包括' and '含括', including their Bopomofo notations. Updated phrase.occ file with occurrence data for '含括'. These changes enhance the phonetic mapping system for the character '括' and its compound words.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1