Fix phonetics for 勾 #573
Open
Fix phonetics for 勾 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`勾當 ㄍㄡˋ ㄉㄤˋ` is the only one with `勾 ㄍㄡˋ`. Add two phrases from the concise dictionary. Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8B%BE#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
Code Review Agent Run #1a0729Actionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
|
The bot also can be confused with Simplified <-> Traditional Chinese conversions. '勾' (钩) in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
勾當 ㄍㄡˋ ㄉㄤˋis the only one with勾 ㄍㄡˋ.Add two phrases from the concise dictionary.
Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8B%BE#searchL
Summary by Bito
Enhanced phonetic mappings for Chinese character '勾' (钩) by adding three new entries to BPMFMappings.txt with their Bopomofo notations. Added entries include '勾當', '打勾勾', and '裡勾外連' along with their corresponding phonetic representations. Updated phrase occurrence data in phrase.occ file.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1