Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phonetics for 劃 #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix phonetics for 劃 #572

wants to merge 1 commit into from

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Jan 31, 2025

劃破 ㄏㄨㄚˊ ㄆㄛˋ is the only ㄏㄨㄚˊ from the concise dictionary.

Add other phrases from the concise dictionary.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8A%83#searchL

Summary by Bito

PR implements phonetic mapping corrections for the Chinese character '划' (hua) and related phrases. Updates include new entries in BPMFMappings.txt for multiple phrases including '划地為王', '划座位', '划破', and '撘划', along with their Bopomofo notations. Occurrence data in phrase.occ file has been updated accordingly.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

`劃破 ㄏㄨㄚˊ  ㄆㄛˋ` is the only `ㄏㄨㄚˊ` from the concise
dictionary.

Add other phrases from the concise dictionary.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8A%83#searchL
@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 14:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Source/Data/BPMFMappings.txt: Language not supported
  • Source/Data/phrase.occ: Language not supported
Copy link

bito-code-review bot commented Jan 31, 2025

Code Review Agent Run #534e75

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: ee8a2fc..ee8a2fc
    • Source/Data/BPMFMappings.txt
    • Source/Data/phrase.occ
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - Phonetic Corrections for Chinese Characters

BPMFMappings.txt - Added phonetic mappings for 劃 (hua) related phrases

phrase.occ - Added occurrence data for new 劃 related phrases

@xatier
Copy link
Contributor Author

xatier commented Jan 31, 2025

It seems like the bot is reviewing the PR with Simplified Chinese in mind, which may not be optimal for this project? The annotation added by the bot also appears to be inaccurate from the actual diff. cc: @lukhnos @zonble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant