Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phonetics for 剖 #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix phonetics for 剖 #571

wants to merge 1 commit into from

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Jan 31, 2025

Remove incorrect pronunciation 剖 ㄆㄛˇ

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%89%96#searchL

Add both pronunciations 剖 ㄆㄡˇ and 剖 ㄆㄡ.

Summary by Bito

Fixed incorrect phonetic mappings for Chinese character '剖' (U+5256) in BPMFMappings.txt. Removed wrong pronunciation 'ㄆㄛˇ' and added correct pronunciations 'ㄆㄡˇ' and 'ㄆㄡ'. Updates include corrections to compound words containing this character to maintain database consistency.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 13:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

bito-code-review bot commented Jan 31, 2025

Code Review Agent Run #414a2f

Actionable Suggestions - 0
Additional Suggestions - 1
  • Source/Data/BPMFMappings.txt - 1
Review Details
  • Files reviewed - 1 · Commit Range: baaf3b6..baaf3b6
    • Source/Data/BPMFMappings.txt
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@xatier
Copy link
Contributor Author

xatier commented Jan 31, 2025

$ ./find.py 剖 ㄆㄡ
人體解剖 ㄖㄣˊ ㄊㄧˇ ㄐㄧㄝˇ ㄆㄡ
剖成 ㄆㄡ ㄔㄥˊ
剖析 ㄆㄡ ㄒㄧ
剖白 ㄆㄡ ㄅㄛˊ
剖白 ㄆㄡ ㄅㄞˊ
剖示圖 ㄆㄡ ㄕˋ ㄊㄨˊ
剖肝泣血 ㄆㄡ ㄍㄢ ㄑㄧˋ ㄒㄧㄝˇ
剖腹 ㄆㄡ ㄈㄨˋ
剖腹生產 ㄆㄡ ㄈㄨˋ ㄕㄥ ㄔㄢˇ
剖腹產 ㄆㄡ ㄈㄨˋ ㄔㄢˇ
剖解 ㄆㄡ ㄐㄧㄝˇ
剖開 ㄆㄡ ㄎㄞ
剖面 ㄆㄡ ㄇㄧㄢˋ
剖面圖 ㄆㄡ ㄇㄧㄢˋ ㄊㄨˊ
橫剖面 ㄏㄥˊ ㄆㄡ ㄇㄧㄢˋ
瓜剖豆分 ㄍㄨㄚ ㄆㄡ ㄉㄡˋ ㄈㄣ
病理解剖 ㄅㄧㄥˋ ㄌㄧˇ ㄐㄧㄝˇ ㄆㄡ
解剖 ㄐㄧㄝˇ ㄆㄡ
解剖刀 ㄐㄧㄝˇ ㄆㄡ ㄉㄠ
解剖學 ㄐㄧㄝˇ ㄆㄡ ㄒㄩㄝˊ
豆剖瓜分 ㄉㄡˋ ㄆㄡ ㄍㄨㄚ ㄈㄣ
開剖 ㄎㄞ ㄆㄡ
開腸剖肚 ㄎㄞ ㄔㄤˊ ㄆㄡ ㄉㄨˋ
$ ./find.py 剖 ㄆㄡˇ
人體解剖 ㄖㄣˊ ㄊㄧˇ ㄐㄧㄝˇ ㄆㄡˇ
剖成 ㄆㄡˇ ㄔㄥˊ
剖析 ㄆㄡˇ ㄒㄧ
剖白 ㄆㄡˇ ㄅㄛˊ
剖白 ㄆㄡˇ ㄅㄞˊ
剖示圖 ㄆㄡˇ ㄕˋ ㄊㄨˊ
剖肝泣血 ㄆㄡˇ ㄍㄢ ㄑㄧˋ ㄒㄧㄝˇ
剖腹 ㄆㄡˇ ㄈㄨˋ
剖腹生產 ㄆㄡˇ ㄈㄨˋ ㄕㄥ ㄔㄢˇ
剖腹產 ㄆㄡˇ ㄈㄨˋ ㄔㄢˇ
剖解 ㄆㄡˇ ㄐㄧㄝˇ
剖開 ㄆㄡˇ ㄎㄞ
剖面 ㄆㄡˇ ㄇㄧㄢˋ
剖面圖 ㄆㄡˇ ㄇㄧㄢˋ ㄊㄨˊ
橫剖面 ㄏㄥˊ ㄆㄡˇ ㄇㄧㄢˋ
瓜剖豆分 ㄍㄨㄚ ㄆㄡˇ ㄉㄡˋ ㄈㄣ
病理解剖 ㄅㄧㄥˋ ㄌㄧˇ ㄐㄧㄝˇ ㄆㄡˇ
解剖 ㄐㄧㄝˇ ㄆㄡˇ
解剖刀 ㄐㄧㄝˇ ㄆㄡˇ ㄉㄠ
解剖學 ㄐㄧㄝˇ ㄆㄡˇ ㄒㄩㄝˊ
豆剖瓜分 ㄉㄡˋ ㄆㄡˇ ㄍㄨㄚ ㄈㄣ
開剖 ㄎㄞ ㄆㄡˇ
開腸剖肚 ㄎㄞ ㄔㄤˊ ㄆㄡˇ ㄉㄨˋ

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - Phonetic Correction for Chinese Character

BPMFMappings.txt - Updated phonetic mappings for '剖' and related compound characters with correct pronunciations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant