Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Codeium PR agent in the CI jobs. #569

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds Codeium PR agent in the CI jobs. #569

wants to merge 5 commits into from

Conversation

zonble
Copy link
Contributor

@zonble zonble commented Jan 12, 2025

Also added two simple phrases.

lukhnos
lukhnos requested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two comments re keeping the phrase source files sorted. Thanks!

Source/Data/BPMFMappings.txt Outdated
@@ -139584,3 +139584,5 @@
龜鑑 ㄍㄨㄟ ㄐㄧㄢˋ
龜頭 ㄍㄨㄟ ㄊㄡˊ
龜鱉目 ㄍㄨㄟ ㄅㄧㄝ ㄇㄨˋ
大於等於 ㄉㄚˋ ㄩˊ ㄉㄥˇ ㄩˊ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the file sorted per the instructions here? https://github.com/openvanilla/McBopomofo/wiki/詞庫開發說明#請確保-bpmfmappingstxt-以及-phraseocc-兩個檔案的詞條排序

Source/Data/phrase.occ Outdated
@@ -148259,3 +148259,5 @@
龤 0
兀 0
嗀 0
大於等於 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto please keep the file sorted.

@zonble zonble requested a review from lukhnos January 20, 2025 00:47
@tianjianjiang
Copy link
Member

/describe

@tianjianjiang
Copy link
Member

/review
--pr_reviewer.inline_code_comments=true
--pr_reviewer.require_score_review=true
--pr_reviewer.require_can_be_split_review=true

@zonble
Copy link
Contributor Author

zonble commented Jan 20, 2025

/review --pr_reviewer.inline_code_comments=true --pr_reviewer.require_score_review=true --pr_reviewer.require_can_be_split_review=true

看起來好像沒作用？

@tianjianjiang
Copy link
Member

@zonble 我印象中只用 GH Actions 的用法有點不同。正要比對。

@tianjianjiang
Copy link
Member

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Title

Adds Codeium PR agent in the CI jobs.

User description

Also added two simple phrases.

PR Type

Enhancement, Other

Description

  • Added a GitHub workflow to integrate Codeium PR agent.

  • Introduced new phrases in BPMFMappings.txt and phrase.occ.

  • Ensured phrase.occ remains sorted after updates.

Changes walkthrough 📝

Relevant files
Configuration changes
codeium-pr-agent.yml
Add GitHub workflow for Codeium PR agent                                 

.github/workflows/codeium-pr-agent.yml

  • Added a new GitHub workflow for Codeium PR agent.
  • Configured the workflow to trigger on pull request events.
  • Set up permissions and environment variables for the workflow.
    		• +22/-0   
    Enhancement
    BPMFMappings.txt
    Add new phrases to BPMFMappings.txt                                           

    Source/Data/BPMFMappings.txt

  • Added two new phrases: "大於等於" and "小於等於".
  • Updated the file with new mappings for these phrases.
    		• +2/-0     
    phrase.occ
    Update phrase occurrences with new entries                             

    Source/Data/phrase.occ

  • Added occurrences for new phrases: "大於等於" and "小於等於".
  • Ensured the file remains sorted after updates.
    		• +2/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @tianjianjiang
    Copy link
    Member

    @CodiumAI-Agent /review --pr_reviewer.inline_code_comments=true --pr_reviewer.require_score_review=true --pr_reviewer.require_can_be_split_review=true

    @CodiumAI-Agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🏅 Score: 92
    🧪 No relevant tests
    🔒 No security concerns identified
    🔀 Multiple PR themes

    Sub-PR theme: Add Codeium PR Agent Workflow

    Relevant files:

    • .github/workflows/codeium-pr-agent.yml
    Sub-PR theme: Add New Phrases to Data Files

    Relevant files:

    • Source/Data/BPMFMappings.txt
    • Source/Data/phrase.occ
    ⚡ Recommended focus areas for review

    Secrets Usage

    Ensure that the secrets OPENAI_KEY and GITHUB_TOKEN are correctly configured and securely stored in the repository settings.

    env:
  OPENAI_KEY: ${{ secrets.OPENAI_KEY }}
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

    tianjianjiang
    tianjianjiang reviewed Jan 20, 2025
    View reviewed changes
    .github/workflows/codeium-pr-agent.yml
    env:
    OPENAI_KEY: ${{ secrets.OPENAI_KEY }}
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    github_action_config.auto_review: "true" # enable\disable auto review
    github_action_config.auto_describe: "true" # enable\disable auto describe
    github_action_config.auto_improve: "true" # enable\disable auto improve
    github_action_config.pr_actions: '["opened", "reopened", "ready_for_review", "review_requested"]'

    @zonble 如果要自動跑的話要有這些。現在沒有，所以要手動 comment @CodiumAI-Agent /command

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    是說我不確定最後一列 github_action_config.pr_actions: '["opened", "reopened", "ready_for_review", "review_requested"]' 跟最上層不一致的話會發生什麼事。現在最上層的 on 沒有 "review_requested".

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    另外，GitHub App 才支援不加 @CodiumAI-Agent 的 /command.

    xatier
    xatier reviewed Jan 20, 2025
    View reviewed changes
    Source/Data/BPMFMappings.txt
    @@ -139669,3 +139669,5 @@
    龜鑑 ㄍㄨㄟ ㄐㄧㄢˋ
    龜頭 ㄍㄨㄟ ㄊㄡˊ
    龜鱉目 ㄍㄨㄟ ㄅㄧㄝ ㄇㄨˋ
    大於等於 ㄉㄚˋ ㄩˊ ㄉㄥˇ ㄩˊ
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    nit: these also need to be sorted.

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What xatier said.

    lukhnos
    lukhnos requested changes Jan 30, 2025
    View reviewed changes
    Source/Data/BPMFMappings.txt
    @@ -139669,3 +139669,5 @@
    龜鑑 ㄍㄨㄟ ㄐㄧㄢˋ
    龜頭 ㄍㄨㄟ ㄊㄡˊ
    龜鱉目 ㄍㄨㄟ ㄅㄧㄝ ㄇㄨˋ
    大於等於 ㄉㄚˋ ㄩˊ ㄉㄥˇ ㄩˊ
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What xatier said.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @tianjianjiang tianjianjiang tianjianjiang left review comments

    @xatier xatier xatier left review comments

    @lukhnos lukhnos lukhnos requested changes

    Requested changes must be addressed to merge this pull request.

    Assignees

    @lukhnos lukhnos

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @zonble @tianjianjiang @CodiumAI-Agent @lukhnos @xatier