UCT/CUDA/CUDA_IPC: cuCtxPushCurrent before cuIpcCloseMemHandle. #10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Apr 10, 2025
Comment on lines
163
to
168
| if (status == UCS_OK) { | ||
| return UCT_CUDADRV_FUNC_LOG_WARN(cuMemAddressFree( | ||
| status = UCT_CUDADRV_FUNC_LOG_WARN(cuMemAddressFree( | ||
| (CUdeviceptr)region->mapped_addr, region->key.b_len)); | ||
| } | ||
|
|
||
| return status; |
There was a problem hiding this comment.
maybe smth like
status = UCT_CUDADRV_FUNC_LOG_WARN(cuMemUnmap(...));
if (status != UCS_OK) {
return status;
}
return UCT_CUDADRV_FUNC_LOG_WARN(cuMemAddressFree(...));
brminich
reviewed
Apr 10, 2025
| ucs_status_t status; | ||
|
|
||
| status = uct_cuda_primary_ctx_retain(cuda_device, 1, &cuda_ctx); |
There was a problem hiding this comment.
minor: imo no need to force, as primary context is supposed to be active
There was a problem hiding this comment.
Why was it forced in uct_cuda_ipc_open_memhandle_legacy?
There was a problem hiding this comment.
probably leftover from the time we thought we need this focring
brminich
previously approved these changes
Apr 10, 2025
yosefe
approved these changes
Apr 10, 2025
rakhmets
force-pushed
the
topic/cuda-ipc-close-memhandle-fix
branch
from
ed1dc49 to
9a52b3c
Compare
brminich
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Push the primary device context before calling
cuIpcCloseMemHandle.Why?
There is a warning if there is no CUDA context bound to the current CPU thread while closing memory handle.