UCP/CORE: disable everything (aux as well) when ^ib is configured #10579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amastbaum
force-pushed
the
disable_aux_implicitly_when_not-ib_configured
branch
from
bbf15ac to
3e602d9
Compare
amastbaum
added
Ready for Review
and removed
WIP-DNM
rakhmets
reviewed
Mar 25, 2025
gleon99
reviewed
Mar 25, 2025
amastbaum
force-pushed
the
disable_aux_implicitly_when_not-ib_configured
branch
from
f0412bd to
8c57b9a
Compare
rakhmets
previously approved these changes
Mar 26, 2025
yosefe
reviewed
Mar 31, 2025
|
can we add some gtest for it? |
or extend Line 1104 in 97b7040 |
|
I can confirm this resolves the original issue, now Thanks everyone for working on this! |
amastbaum
force-pushed
the
disable_aux_implicitly_when_not-ib_configured
branch
from
8c57b9a to
ea48471
Compare
rakhmets
previously approved these changes
Apr 7, 2025
yosefe
reviewed
Apr 8, 2025
test/apps/test_ucx_tls.py
Outdated
| if (override): | ||
| os.putenv("UCX_NUM_EPS", "2") | ||
|
|
||
| with _override_env("UCX_TLS", tls): |
There was a problem hiding this comment.
can we extract common code with find_am_transport?
gleon99
reviewed
Apr 8, 2025
gleon99
reviewed
Apr 8, 2025
gleon99
reviewed
Apr 10, 2025
yosefe
reviewed
Apr 14, 2025
yosefe
approved these changes
Apr 14, 2025
amastbaum
force-pushed
the
disable_aux_implicitly_when_not-ib_configured
branch
from
3320a51 to
19ca9ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Setting
UCX_TLS=^ibnow disables all ib transports, including auxiliary ones.For other aliases, auxiliary disabling must be explicitly specified.
Why?
Based on #8778, when disabling ud based transports, they should still be available as auxiliary. Thus,
UCX_TLS=^uddoes not disable their auxiliary usage.However, we still want
UCX_TLS=^ibto be treated as a global exclusion of all ib transports, including auxiliary ones.To support this, a new distinction now differentiates global aliases (e.g. ib) from specific aliases (e.g. ud, rc, etc.).