UCM/CUDA: Correct region size for pitched CUDA allocation hooks #10527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranix
force-pushed
the
master
branch
2 times, most recently
from
3c9dcc2 to
985bcc6
Compare
|
@hoopoepg Please have a look at this PR when you get a chance. There are some failed checks, but I don't think they are related |
|
hello, have you or your organization signed the CLA https://openucx.org/license/? |
|
No, not yet. Planning to sign an individual CLA, because PR is unrelated to my organization. Is it still possible to send a signed version via email as described here? UPD: Sorry, found it at the very top of "Guidance for contributors" page |
yosefe
reviewed
Mar 5, 2025
yosefe
reviewed
Mar 5, 2025
yosefe
previously approved these changes
Mar 5, 2025
rakhmets
previously approved these changes
Mar 6, 2025
Co-authored-by: Raul Akhmetshin <[email protected]>
rakhmets
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For pitched CUDA memory allocations (cuMemAllocPitch, cuMemAllocPitch_v2, cudaMallocPitch, cudaMalloc3D) the allocated region may be bigger than requested. The UCM code incorrectly marked those regions to have
width * height[ * depth]size, but their actual size ispitch * height[ * depth].Why?
Incorrect allocated region size leads to part of it having incorrect UCS_MEMORY_TYPE and further attempts to access device memory as host memory.
Closes #10526