TL/UCP: add linear alltoall(v) #1116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikryukov
reviewed
Apr 17, 2025
| @@ -75,7 +48,7 @@ void ucc_tl_ucp_alltoall_pairwise_progress(ucc_coll_task_t *coll_task) | |||
| ((task->tagged.recv_posted - task->tagged.recv_completed) < | |||
| nreqs)) { | |||
| peer = get_recv_peer(grank, gsize, task->tagged.recv_posted); | |||
| UCPCHECK_GOTO(ucc_tl_ucp_recv_nb((void *)(rbuf + peer * data_size), | |||
| UCPCHECK_GOTO(ucc_tl_ucp_recv_nb(PTR_OFFSET(rbuf, peer * data_size), | |||
There was a problem hiding this comment.
if ucc_tl_ucp_recv_nb returns UCC_INPROGRESS it jumps to out, but you could still post more tasks to match nreq tasks in flight
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add linear alltoall and alltoallv algorithms to TL/UCP