TL/MLX5: ctx global status check #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
force-pushed
the
topic/mlx5_do_global_status_check
branch
from
35befbd to
4a30768
Compare
Sergei-Lebedev
force-pushed
the
topic/mlx5_do_global_status_check
branch
from
4a30768 to
5cd1a47
Compare
samnordmann
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Thank you for the patch!
Not a request, but for readability, I would suggest to move topo and rcache init out of
ucc_tl_mlx5_context_ib_ctx_pd_setup and place it directly in ucc_tl_mlx5_context_create_epilog
But if this causes too much refactoring, we probably shouldn't bother
janjust
approved these changes
Apr 22, 2025
janjust
force-pushed
the
topic/mlx5_do_global_status_check
branch
from
5cd1a47 to
20e48c3
Compare
|
/bot:retest |
Added checks for successful creation of the rcache and topology initialization.
janjust
force-pushed
the
topic/mlx5_do_global_status_check
branch
from
20e48c3 to
b12664e
Compare
MamziB
pushed a commit
to MamziB/ucc-forked
that referenced
this pull request
Jul 9, 2025
Added checks for successful creation of the rcache and topology initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added checks for successful creation of the rcache and topology initialization.
Why ?
All the resource initialization must happen in context create epilog. Otherwise if context create fails on one rank the other ranks will hang in context create epilog broadcast