Add support for ucc_mem_map and ucc_mem_unmap #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
wfaderhold21
force-pushed
the
topic/explicit-mem-map-impl
branch
from
61ab0da to
4a2f9c6
Compare
|
@janjust @nsarka Can you test on your setup? Ask @wfaderhold21 for details. |
wfaderhold21
force-pushed
the
topic/explicit-mem-map-impl
branch
from
f02340e to
41f0b4e
Compare
wfaderhold21
force-pushed
the
topic/explicit-mem-map-impl
branch
from
1a327f1 to
ebc57c5
Compare
|
Example user usage of API changes: https://github.com/wfaderhold21/simple-ucc-ex |
wfaderhold21
commented
Feb 20, 2025
wfaderhold21
commented
Feb 20, 2025
wfaderhold21
commented
Feb 20, 2025
wfaderhold21
commented
Feb 20, 2025
wfaderhold21
commented
Feb 20, 2025
wfaderhold21
commented
Feb 20, 2025
aamirshafi
reviewed
Feb 20, 2025
wfaderhold21
requested review from
janjust,
Sergei-Lebedev,
nsarka and
samnordmann
wfaderhold21
force-pushed
the
topic/explicit-mem-map-impl
branch
from
23d5050 to
9691c1f
Compare
|
@Sergei-Lebedev Thank you for the feedback. I believe I have addressed all your concerns. Please let me know if I haven't. |
|
@janjust do we need more code review concerning this PR or can we apply the completed label? |
thanks, I reviewed only part of this PR since it's big. I will continue reviewing this week. |
samnordmann
reviewed
Mar 5, 2025
janjust
added
Arch-Review-Completed
Code-Review-Completed
and removed
Code-Review-Required
labels
added 26 commits
June 12, 2025 10:49
CL/BASIC: add support for ucc_mem_map/unmap CL/HIER: add support for ucc_mem_map/unmap CL/DOCA_UROM: add support for ucc_mem_map/unmap TL/CUDA: add support for ucc_mem_map/unmap TL/MLX5: add support for ucc_mem_map/unmap TL/NCCL: add support for ucc_mem_map/unmap TL/RCCL: add support for ucc_mem_map/unmap TL/SELF: add support for ucc_mem_map/unmap TL/SHARP: add support for ucc_mem_map/unmap
TL/UCP: add support for communication with memmap REVIEW: various fixes TL/UCP: Enable multiple packed buffers
TL/UCP: additional support for memh in onesided alltoall
janjust
force-pushed
the
topic/explicit-mem-map-impl
branch
from
4b7b11d to
0870c18
Compare
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implementation of PR #1037
NOTE: branch is branched from #1037 and will need to be rebased before merging