Skip to content

Conversation

@vesameskanen
Copy link
Contributor

Summary

PR #6774 introduced a new bug by blocking traversal through entrance nodes which belong to a barrier. This PR fixes the mentioned bug.

An example: https://www.openstreetmap.org/node/394848762

Issue

No issue created, this is a simple bug fix.

Unit tests

Unit test added.

@vesameskanen vesameskanen requested a review from a team as a code owner November 18, 2025 08:23
@vesameskanen vesameskanen added the !Bug Apply to issues describing a bug and PRs witch fixes it. label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.29%. Comparing base (4ed53a0) to head (bf7ce37).

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #7067   +/-   ##
==========================================
  Coverage      72.28%   72.29%           
- Complexity     20180    20183    +3     
==========================================
  Files           2189     2189           
  Lines          81217    81217           
  Branches        8140     8140           
==========================================
+ Hits           58710    58712    +2     
+ Misses         19632    19631    -1     
+ Partials        2875     2874    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried
Copy link
Member

Since the test was a copy&paste job, I took the liberty to convert it to a parameterized test. If you agree with this, can you apply this commit? leonardehrenfried@259822a

@t2gran t2gran added this to the 2.9 (next release) milestone Nov 19, 2025
Copy link
Contributor

@miklcct miklcct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this now.

There may be some problems in the definition of what an entrance is (for example, entrance=secondary is missing on the list) but it is better handled in another PR.

@miklcct miklcct merged commit c235cab into opentripplanner:dev-2.x Nov 19, 2025
8 checks passed
t2gran pushed a commit that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants