-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Handle barrier entrances correctly #7067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle barrier entrances correctly #7067
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7067 +/- ##
==========================================
Coverage 72.28% 72.29%
- Complexity 20180 20183 +3
==========================================
Files 2189 2189
Lines 81217 81217
Branches 8140 8140
==========================================
+ Hits 58710 58712 +2
+ Misses 19632 19631 -1
+ Partials 2875 2874 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since the test was a copy&paste job, I took the liberty to convert it to a parameterized test. If you agree with this, can you apply this commit? leonardehrenfried@259822a |
miklcct
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this now.
There may be some problems in the definition of what an entrance is (for example, entrance=secondary is missing on the list) but it is better handled in another PR.
Summary
PR #6774 introduced a new bug by blocking traversal through entrance nodes which belong to a barrier. This PR fixes the mentioned bug.
An example: https://www.openstreetmap.org/node/394848762
Issue
No issue created, this is a simple bug fix.
Unit tests
Unit test added.