Fix coordinate fallback when linking locations in the street graph #7056
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a GenericLocation contains both a stopId that doesn't exist in the graph and valid coordinates, the system should fall back to using the coordinates to create a temporary vertex. This was the behavior before PR opentripplanner#6972 (temporary-vertex-refactor). The regression was caused by mutually exclusive if/else if logic in LinkingContextFactory.getStreetVerticesForLocation(). When location.stopId was present but not found in the graph, the method would return an empty set without checking if coordinates were available. This commit restores the fallback behavior by checking if results are empty after the stop ID lookup and, if coordinates are available, using them to create a vertex. This allows robust queries that provide both place IDs and coordinates for redundancy. Fixes the issue where GraphQL trip queries with non-existing place IDs and valid coordinates would return empty results instead of using the coordinate fallback.
Add test case that verifies when a GenericLocation contains both a stopId that doesn't exist in the graph and valid coordinates, the system falls back to using the coordinates to create a temporary vertex rather than throwing a RoutingValidationException. This test documents the expected behavior that was broken by PR opentripplanner#6972 and is now fixed.
vpaturet
force-pushed
the
fix-coordinate-fallback
branch
from
b8469ee to
7002ae6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7056 +/- ##
=============================================
+ Coverage 72.23% 72.49% +0.25%
- Complexity 20169 20456 +287
=============================================
Files 2188 2206 +18
Lines 81186 82240 +1054
Branches 8141 8229 +88
=============================================
+ Hits 58645 59619 +974
- Misses 19667 19699 +32
- Partials 2874 2922 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vpaturet
changed the title
Contributor
Author
|
Tested this in our staging environment, this fixes the problem that users reported. |
optionsome
reviewed
Nov 14, 2025
Comment on lines
315
to
321
| var fromVertices = linkingContext.findVertices(from); | ||
| assertThat(fromVertices).hasSize(1); | ||
| assertThat(fromVertices).isNotEmpty(); | ||
|
|
||
| var toVertices = linkingContext.findVertices(to); | ||
| assertThat(toVertices).hasSize(1); | ||
| assertThat(toVertices).isNotEmpty(); |
Member
There was a problem hiding this comment.
I think this you might want to check that these vertices are also of type TemporaryStreetLocation as stop vertices might also end up in these collection.
optionsome
added
the
!Bug
leonardehrenfried
approved these changes
Nov 19, 2025
optionsome
approved these changes
Nov 19, 2025
t2gran
pushed a commit
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for #7055: it restores the fallback mechanism in case the provided place id is not found in the stop repository.
Issue
Closes #7055
Unit tests
Added unit test
Documentation
No
Changelog
skip