Add walk safety into OsmTagMapper #6944
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # application/src/main/java/org/opentripplanner/osm/tagmapping/OsmTagMapper.java # application/src/test/java/org/opentripplanner/generate/doc/OsmMapperDocTest.java # application/src/test/java/org/opentripplanner/osm/tagmapping/GermanyMapperTest.java # application/src/test/java/org/opentripplanner/osm/tagmapping/OsmTagMapperTest.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/TransitSnapshotTest.snap # application/src/test/resources/speedtest/travelSearch-expected-results-bd.csv # doc/user/osm/Finland.md # doc/user/osm/Germany.md # doc/user/osm/OsmTag.md # doc/user/osm/UK.md
# Conflicts: # application/src/test/java/org/opentripplanner/generate/doc/OsmMapperDocTest.java
# Conflicts: # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/BikeRentalSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/CarSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/TransitSnapshotTest.snap # application/src/test/resources/speedtest/travelSearch-expected-results-bd.csv # application/src/test/resources/speedtest/travelSearch-expected-results-mc.csv # application/src/test/resources/speedtest/travelSearch-expected-results-md.csv # application/src/test/resources/speedtest/travelSearch-expected-results-sr.csv
This reverts commit a4f5676.
# Conflicts: # application/src/main/java/org/opentripplanner/osm/tagmapping/OsmTagMapper.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap # doc/user/osm/Finland.md # doc/user/osm/Germany.md # doc/user/osm/OsmTag.md # doc/user/osm/UK.md
# Conflicts: # application/src/main/java/org/opentripplanner/osm/tagmapping/OsmTagMapper.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/BikeRentalSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/CarSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/TransitSnapshotTest.snap # application/src/test/resources/speedtest/travelSearch-expected-results-mc.csv # application/src/test/resources/speedtest/travelSearch-expected-results-md.csv # application/src/test/resources/speedtest/travelSearch-expected-results-srr.csv # doc/user/osm/Finland.md # doc/user/osm/Germany.md # doc/user/osm/OsmTag.md # doc/user/osm/UK.md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6944 +/- ##
=============================================
- Coverage 72.20% 72.13% -0.08%
- Complexity 20134 20149 +15
=============================================
Files 2183 2183
Lines 81108 80882 -226
Branches 8144 8146 +2
=============================================
- Hits 58561 58341 -220
- Misses 19666 19667 +1
+ Partials 2881 2874 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap
# Conflicts: # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/BikeRentalSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/TransitSnapshotTest.snap # doc/user/osm/Finland.md # doc/user/osm/Germany.md # doc/user/osm/OsmTag.md # doc/user/osm/UK.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds walk safety into the base OsmTagMapper, where previously it is always 1 (apart from trunk roads which were set as 7.47 as a recent addition).
This is created as a result of a suggestion by @optionsome to remove the addition of walk safety from #6767, therefore this depends on it.
It shouldn't change any values for subclasses where walk safety are set.
Issue
N/A
Unit tests
Updated.
Documentation
Updated
Changelog
Bumping the serialization version id