-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Carpooling POC #6791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
Carpooling POC #6791
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6791 +/- ##
=============================================
- Coverage 72.49% 72.12% -0.37%
- Complexity 20460 20615 +155
=============================================
Files 2206 2232 +26
Lines 82240 83274 +1034
Branches 8229 8345 +116
=============================================
+ Hits 59622 60064 +442
- Misses 19699 20275 +576
- Partials 2919 2935 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7ef5e89 to
79de33f
Compare
ba29af0 to
800d5a3
Compare
7067369 to
408397a
Compare
It doesn't test functionality in any detail and can easily be removed.
…ts cleaning up CarpoolTrip.
…s for a CarpoolTrip. They really are just the first and last stop for a trip. This change also keeps all the various times for a stop location.
...cation/src/ext/java/org/opentripplanner/ext/carpooling/service/DefaultCarpoolingService.java
Outdated
Show resolved
Hide resolved
application/src/ext/java/org/opentripplanner/ext/carpooling/routing/InsertionCandidate.java
Show resolved
Hide resolved
application/src/ext/java/org/opentripplanner/ext/carpooling/routing/InsertionEvaluator.java
Outdated
Show resolved
Hide resolved
application/src/ext/java/org/opentripplanner/ext/carpooling/routing/InsertionEvaluator.java
Outdated
Show resolved
Hide resolved
...cation/src/ext/java/org/opentripplanner/ext/carpooling/service/DefaultCarpoolingService.java
Outdated
Show resolved
Hide resolved
application/src/ext/java/org/opentripplanner/ext/carpooling/updater/CarpoolSiriMapper.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/apis/transmodel/model/EnumTypes.java
Show resolved
Hide resolved
|
I am ready to approve this, but there is one reminding comment that needs a answer: https://github.com/opentripplanner/OpenTripPlanner/pull/6791/files#r2519853610 |
…ameters and SiriETUpdaterParameters.
…daterParameters.java and reuses the vanilla versions.
Resolved merge conflict in doc/user/Configuration.md by: 1. Accepting incoming changes from dev-2.x 2. Regenerating documentation via ConfigurationDocTest The regenerated file includes both dev-2.x changes and carpooling feature.
Summary
This PR introduces carpooling as a sandbox feature in OTP, enabling passengers to be matched with shared carpool trips and integrating carpooling into multi-modal journey planning.
Key capabilities:
Implementation approach:
OTPFeature.CarPoolingtoggleContext:
This POC enables pilot programs where carpooling services integrate with public transit. Development is expected to take at least one year as we refine the feature based on pilot feedback and work with SIRI standardization in parallel.
What's Included
Core Routing
Data Management
SiriETCarpoolingUpdaterPerformance Optimizations
API Integration
CarpoolLeg)What's NOT Included (Future Work)
Not in this PR:
Configuration
Enable feature:
Issue
Part of #7012 (carpooling feature request)
Supersedes #6604 (original POC issue)
Unit tests
189+ carpooling-specific tests (100% passing)
Test infrastructure includes builders and mocks for fast, isolated testing without graph infrastructure.
Documentation
JavaDoc throughout codebase
Changelog
Added:
Configuration:
Bumping the serialization version id
N/A - Sandbox feature does not require serialization bump (carpool trips stored in-memory only, not in graph.obj).
Migration / Compatibility
No breaking changes - all functionality behind OTPFeature.CarPooling toggle (disabled by default).