Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37: Incorrect os architecture detection on localized OS #38

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

abstractionfactory
Copy link
Contributor

@abstractionfactory abstractionfactory commented Nov 5, 2024

This change replaces the call to Get-CimInstance Win32_operatingsystem, which returns a localized string (e.g. 64-bitowy on a Polish OS) with [Environment]::Is64BitOperatingSystem

Fixes: #37
Blocked by: #40

This change replaces the call to Get-CimInstance Win32_operatingsystem, which returns a localized string (e.g. 64-bitowy on a Polish OS) with [Environment]::Is64BitOperatingSystem.

Signed-off-by: AbstractionFactory <[email protected]>
Copy link

Deploying opentofu-get with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f98b56
Status: ✅  Deploy successful!
Preview URL: https://7262f40f.opentofu-get.pages.dev
Branch Preview URL: https://fix-localized-os-download.opentofu-get.pages.dev

View logs

@abstractionfactory abstractionfactory marked this pull request as ready for review November 5, 2024 07:33
@abstractionfactory abstractionfactory self-assigned this Nov 5, 2024
@abstractionfactory abstractionfactory added the bug Something isn't working label Nov 5, 2024
@abstractionfactory abstractionfactory requested a review from a team November 5, 2024 07:53
@abstractionfactory abstractionfactory changed the base branch from main to fix-fedora November 5, 2024 09:14
Base automatically changed from fix-fedora to main November 5, 2024 09:36
@abstractionfactory abstractionfactory merged commit 87f2749 into main Nov 5, 2024
33 of 97 checks passed
@abstractionfactory abstractionfactory deleted the fix-localized-os-download branch November 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powershell script downloads 32-bit version on non-English Windows versions
2 participants