Skip to content

fix(theme-saas): add margin-bottom:4px for select-dropdown flip to top #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented May 7, 2025

PR

select的下拉面板翻转到上面的时候,应该在底部有4px的间距

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Improved vertical spacing for the select dropdown component by adding a small bottom margin.

Copy link

coderabbitai bot commented May 7, 2025

Walkthrough

A bottom margin utility class (mb-1) was added to the select dropdown component's CSS, alongside the existing top margin class (mt-1). This change updates the vertical spacing around the dropdown popper element by providing additional margin below it.

Changes

File(s) Change Summary
packages/theme-saas/src/select-dropdown/index.less Added mb-1 class to the dropdown popper for extra bottom spacing.

Poem

A dropdown floats with margin neat,
Now cushioned both above and beneath.
With mb-1 and mt-1 in tow,
The popper’s spacing’s set to go!
CSS tweaks, a gentle breeze—
Dropdowns land with stylish ease.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f98b936 and 1b8b1dc.

📒 Files selected for processing (1)
  • packages/theme-saas/src/select-dropdown/index.less (1 hunks)
🔇 Additional comments (1)
packages/theme-saas/src/select-dropdown/index.less (1)

27-30: Ensure proper bottom spacing when flipped to top
Adding @apply mb-1; alongside the existing @apply mt-1; on the popper variant provides the intended 4px margin beneath the dropdown panel, matching the spacing above it and satisfying the PR objective of proper flip-to-top spacing.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label May 7, 2025
Copy link

Walkthrough

This PR addresses a UI issue where the select dropdown panel, when flipped to the top, lacked a margin at the bottom. The change introduces a 4px margin-bottom to ensure proper spacing.

Changes

File Summary
packages/theme-saas/src/select-dropdown/index.less Added @apply mb-1; to ensure a 4px margin at the bottom when the dropdown flips to the top.

@@ -26,6 +26,7 @@

&.@{popper-prefix-cls} {
@apply mt-1;
@apply mb-1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the @apply mb-1; correctly applies a 4px margin. Verify that this change does not affect other dropdown positions or styles.

@@ -26,6 +26,7 @@

&.@{popper-prefix-cls} {
@apply mt-1;
@apply mb-1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme默认的样式不需要修改嘛?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要修改, 我们的主题整改时,已经修改实现了。

@zzcr zzcr merged commit 0b47009 into dev May 8, 2025
11 checks passed
@zzcr zzcr deleted the shen/fix-select-flip-margin-bottom branch May 8, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants