-
Notifications
You must be signed in to change notification settings - Fork 300
fix(theme-saas): add margin-bottom:4px for select-dropdown flip to top #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA bottom margin utility class ( Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses a UI issue where the select dropdown panel, when flipped to the top, lacked a margin at the bottom. The change introduces a 4px margin-bottom to ensure proper spacing. Changes
|
@@ -26,6 +26,7 @@ | |||
|
|||
&.@{popper-prefix-cls} { | |||
@apply mt-1; | |||
@apply mb-1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the @apply mb-1;
correctly applies a 4px margin. Verify that this change does not affect other dropdown positions or styles.
@@ -26,6 +26,7 @@ | |||
|
|||
&.@{popper-prefix-cls} { | |||
@apply mt-1; | |||
@apply mb-1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theme默认的样式不需要修改嘛?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要修改, 我们的主题整改时,已经修改实现了。
PR
select的下拉面板翻转到上面的时候,应该在底部有4px的间距
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit