Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soul war - taints exp passive #3145

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

LeoTKBR
Copy link
Contributor

@LeoTKBR LeoTKBR commented Nov 22, 2024

  • Exp bonus for the amount of taints you have from soul war

LeoTKBR and others added 4 commits November 22, 2024 14:20
- Exp bonus for the amount of taints you have from soul war
I noticed that as it will be executed several times for each monster killed, I made this optimization.
@FelipePaluco
Copy link
Contributor

You can encapsulate this table inside the already existing table of Soul War.

@LeoTKBR
Copy link
Contributor Author

LeoTKBR commented Nov 22, 2024

You can encapsulate this table inside the already existing table of Soul War.

the variable is local:
soul localWarTaints

it is not global.

@LeoTKBR LeoTKBR closed this Nov 22, 2024
@LeoTKBR LeoTKBR deleted the patch-2 branch November 22, 2024 23:30
@LeoTKBR LeoTKBR restored the patch-2 branch November 23, 2024 22:46
@LeoTKBR LeoTKBR reopened this Nov 23, 2024
Copy link

sonarcloud bot commented Nov 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants