perf: refactor imbuement decay to per-item management #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the imbuement decay system to manage individual items directly instead of iterating through all players. This improves performance by: Tracking only items with active imbuements. Scheduling events dynamically based on items needing updates. Reducing redundant checks and player-wide loops. Simplifying imbuement decay logic while preserving existing functionality, including protection zone, fight mode, and backpack-specific rules. This change optimizes the handling of imbuements and ensures better scalability.
dudantas
force-pushed
the
dudantas/perf-check-imbuements
branch
from
14deabf
to
c001339
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the imbuement decay system, changing it from a player-wide loop to a per-item approach. This significantly optimizes performance by reducing redundant checks and focusing only on items that require decay updates. The refactor includes:
Resolves #3135
Behaviour
Actual
The previous implementation iterated through all players and their inventory items to process imbuement decay. This led to unnecessary overhead, even for players with no relevant items.
Expected
The new implementation tracks only items with active imbuements, dynamically managing their decay schedule and conditions. This minimizes unnecessary processing and ensures accurate decay handling.
Type of change
How Has This Been Tested
The changes were tested with the following scenarios:
Checklist