Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: party shared experience #3133

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

phacUFPE
Copy link
Contributor

Description

This fixes the party shared experience that was not providing the correct amount of experience giving the unique vocations count and party size.

Behaviour

Actual

Party shared experience does not provide the correct amount of experience.

e.g.: A monster with 6000 base experience, with stamina bonus without party it gives 9000, within a party with two unique vocations it only gives around 4800.

Party shared experience does provide the correct amount of experience.

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Create a party with the desired size and vocations
  • Kill a monster with shared experience active

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants