make updates to enable better docs site generation #2967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+226
to
+231
| subtensor = AsyncSubtensor(network="finney") | ||
| await subtensor.initialize() | ||
| # Close when done | ||
| await subtensor.close() | ||
| balance = await subtensor.get_balance(address="5F...") | ||
| await subtensor.close() |
Contributor
There was a problem hiding this comment.
I would highly recommend we steer people toward using the context manager:
async with AsyncSubtensor(network="finney") as subtensor:
balance = await subtensor.get_balance(address="5F...")While both solutions work. People are much more prone to forget to await subtensor.close() with the other method.
Contributor
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome!
Due to GitHub limitations,
please switch to Preview for links to render properly.
Please choose the right template for your pull request: