chore(ci): add label workflow #2003
Open
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
approved these changes
Apr 3, 2025
| script: | | ||
| const pr = context.payload.pull_request; | ||
| if (!pr) { | ||
| console.log("Could not get PR from context"); |
There was a problem hiding this comment.
This should probably fail and indicate an error, right? Maybe we want a label like 'UNLABELABLE' or something? But i guess without the PR there is nothing to label?
| // Optional: Add logic for 'synchronize' if you uncomment it in the 'on:' section | ||
| // else if (context.payload.action === 'synchronize') { ... } | ||
| else { | ||
| console.log(`Unhandled action type: ${context.payload.action}. No labeling action taken.`); |
There was a problem hiding this comment.
Maybe error log messages such as this one should step summaries or otherwise easier to access?
| } else if (isExternal && hasExternalLabel) { | ||
| console.log(`Author is external, but label "${externalLabel}" is already present.`); | ||
| } else { | ||
| console.log(`Author association "${authorAssociation}" is internal or label already present. No label added.`); |
There was a problem hiding this comment.
You already handle the case where the label is present above. You probably want to remove the label if it is labelled as external, but maybe just note that it is?
Suggested change
| console.log(`Author association "${authorAssociation}" is internal or label already present. No label added.`); | |
| if (hasExternalLabel) { | |
| console.log(`Author association "${authorAssociation}" is internal. However, external contributor label is present.`); | |
| } else { | |
| console.log(`Author association "${authorAssociation}" is internal. No label added.`); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding label workflow which has one job at this time and that is to label pull requests with
external-contributorif the user opening the pull request is not a member of the org.This workflow keys off of
author_associationsfrom the pull request context.Best link that I could find to describe each association
In the future we can add different jobs to label issues and pull requests.
Checklist
Testing Instructions