Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Add FilterComponent on Profile and Association pages #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louwenjjr
Copy link
Contributor

@louwenjjr louwenjjr commented Oct 31, 2024

[Platform]: Add FilterComponent on Profile and Association pages

Description

Added filter buttons to Profile and Association pages. To do so, the DataSources that are currently selected in the filter Modal are stored in the AssociationsStateContext and ProfileStateContext is created to store the currently selected Profile sections on the Profile page. Using localStorage the filters are stored. I also added a commit to convert the functionalities to TS.

You can find a working example deployed on The Hyve's demo server. Please let us know what you guys think and if you would like to add it/parts to your repo.

Example of the Association page:
image

Example of the Profile page:
image

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A: local deployment with yarn. Visited all pages and checked functionalities.
  • Test B: compiling TS code did not yield additional errors.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

It can filter out sections/data sources by using the new ProfileContext and
the existing AssociationsContext. Filter selection persists in browser cache
@carcruz
Copy link
Contributor

carcruz commented Oct 31, 2024

Thanks for your PR, @louwenjjr. It's an exciting feature for AotF.

To make it easier to review, test, and work on top of it, can you please remove all the nonrelated changes to the feature?

For example, any change made in the platform/pages/, neither packages/sections/, nor should be part of this PR.

@louwenjjr
Copy link
Contributor Author

louwenjjr commented Oct 31, 2024

Thanks for your PR, @louwenjjr. It's an exciting feature for AotF.

To make it easier to review, test, and work on top of it, can you please remove all the nonrelated changes to the feature?

For example, any change made in the platform/pages/, neither packages/sections/, nor should be part of this PR.

Thanks for the quick reply @carcruz! I also implemented the filter on the profile pages that's why you see changes in those parts of the codebase. See as well the example image I added.

Of course it is okay if you only want to include the filter functionality on the Association page. In that case I will split the PR, so let me know!

@chinmehta chinmehta added the community Open source contributions from community label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Open source contributions from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants