Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: labels for dataproc in dev mode #987

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

project-defiant
Copy link
Contributor

✨ Context

Ensure we track the cost of the local dataproc clusters with labels build from gentropy Makefile.

🛠 What does this PR implement

This PR adds labels to the make create-dev-cluster command to ensure we can refer to the costs of the dataproc clusters post mortem.

Added labels:

  1. team=open-targets
  2. subteam=gentropy
  3. created_by=$(USER)
  4. environment=development
    The format of the label see docs

These labels attempt to follow the standard created for the unified pipeline.

image

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g uv run pre-commit run --all-files)?

@project-defiant project-defiant force-pushed the szsz-add-labels-to-dataproc-cluster branch from d556305 to a1a22bf Compare February 3, 2025 13:38
@project-defiant project-defiant marked this pull request as ready for review February 3, 2025 13:55
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding tags for dataproc clusters created by users via the create-dev-cluster Makefile rule. This allows better tracking! Great!

@DSuveges DSuveges merged commit 3f204dc into dev Feb 3, 2025
7 checks passed
@project-defiant project-defiant deleted the szsz-add-labels-to-dataproc-cluster branch February 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants