Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak spark session builder to fix type hints #982

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Jan 30, 2025

✨ Context

Updating to pyspark 3.5.4 seems to have broken type hinting for some of Session()'s functionality.

🛠 What does this PR implement

Changes the way spark sessions are built to fix the issue.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-XS labels Jan 30, 2025
@project-defiant
Copy link
Contributor

project-defiant commented Feb 3, 2025

@Daniel-Considine TBH, I am not sure if this change does anything - see the source code of pyspark 3.5.4 builder property

Copy link
Contributor

@project-defiant project-defiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at this

@project-defiant project-defiant self-requested a review February 3, 2025 11:15
Copy link
Contributor

@project-defiant project-defiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: after double checking on dev branch I have the same issue with vscode

@Daniel-Considine Daniel-Considine merged commit e2832a3 into dev Feb 3, 2025
7 checks passed
@Daniel-Considine Daniel-Considine deleted the dc_fix_session_typing branch February 3, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants