Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert pre-commit update (a99ca8490ae6feab2494f9283f49b329d488116b) #980

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ireneisdoomed
Copy link
Contributor

✨ Context

Last merged PR (#976 ) causes pre-commit checks to fail with error error: can't find Rust compiler

Temporarily reverting the changes fix the issue.

🛠 What does this PR implement

#976 introduced a jump in Ruff pre-commit from v0.7.4 to v0.9.3 could have introduced new features or changes that require Rust to be installed, especially since Ruff heavily relies on the Rust toolchain for performance.

🙈 Missing

I have tried adding the Rust installation inside install-dependencies.sh like so:

if ! command -v rustc &>/dev/null; then
    echo "Rust was not found, installing Rust..."
    curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
    source "$HOME/.cargo/env"
    echo "Rust installed successfully."
fi

but that didn't fix the issue. I'm simply reverting back these changes.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g uv run pre-commit run --all-files)?

@ireneisdoomed ireneisdoomed marked this pull request as ready for review January 28, 2025 17:35
@ireneisdoomed ireneisdoomed requested a review from xyg123 January 28, 2025 17:36
Copy link
Contributor

@xyg123 xyg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ireneisdoomed ireneisdoomed merged commit 040bbf8 into dev Jan 28, 2025
7 checks passed
@ireneisdoomed ireneisdoomed deleted the il-pre-commit-fix branch January 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants