-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP to address issue 153 and sketching out some ideas #791
base: develop
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Importing design days appears to be working
|
||
// Evan note: do not remove existing design days | ||
//for (model::SizingPeriod sizingPeriod : m_model.getModelObjects<model::SizingPeriod>()){ | ||
// sizingPeriod.remove(); | ||
//} | ||
|
||
//m_model.insertObjects(ddyModel.objects()); | ||
designDaysToInsert = showDesignDaySelectionDialog(summerdays99, summerdays99_6, summerdays2, summerdays1, summerdays0_4, winterDays99, winterDays99_6, winterDays2, winterDays1, winterDays0_4,allNonAnnual); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would pass all the design days in in a single vector. Then the widget could do all the sorting, doing all this pre-sorting up front is kind of messy.
Thanks @antonszilasi! I think the first thing to do is to create a mockup of the UI that we want to make, the unmethours post suggested this from Trace: Once we have the mockup, we can create the widget to match it. |
@macumber thanks for the feedback, I need to work on the presentation but I think this will do in terms of functionality I just want to keep it basic with not too many bells and whistles we can expand on it later if other users request it |
WIP to address issue 153 and sketching out some ideas