Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP to address issue 153 and sketching out some ideas #791

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

antonszilasi
Copy link

@antonszilasi antonszilasi commented Feb 16, 2025

WIP to address issue 153 and sketching out some ideas

Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@antonszilasi antonszilasi changed the title Dev/anton/153 WIP to address issue 153 and sketching out some ideas Feb 16, 2025

// Evan note: do not remove existing design days
//for (model::SizingPeriod sizingPeriod : m_model.getModelObjects<model::SizingPeriod>()){
// sizingPeriod.remove();
//}

//m_model.insertObjects(ddyModel.objects());
designDaysToInsert = showDesignDaySelectionDialog(summerdays99, summerdays99_6, summerdays2, summerdays1, summerdays0_4, winterDays99, winterDays99_6, winterDays2, winterDays1, winterDays0_4,allNonAnnual);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pass all the design days in in a single vector. Then the widget could do all the sorting, doing all this pre-sorting up front is kind of messy.

@macumber
Copy link
Collaborator

Thanks @antonszilasi! I think the first thing to do is to create a mockup of the UI that we want to make, the unmethours post suggested this from Trace:

image

Once we have the mockup, we can create the widget to match it.

@macumber
Copy link
Collaborator

macumber commented Feb 16, 2025

What about something like below:

image

We would look through the file and identify all the design day types and levels, then group them in a table. Each row would allow selecting one radio button. Each column would have a select all button to select all in that column

@antonszilasi
Copy link
Author

@macumber thanks for the feedback, I need to work on the presentation but I think this will do in terms of functionality

I just want to keep it basic with not too many bells and whistles we can expand on it later if other users request it

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants