Fix #633 - Apply short style copyright and hopefully for the last time #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of sync + add Qt6Chars and Qt6OpenGLWidgets
jmarrec
force-pushed
the
633_ShortStyleCopyright
branch
from
2c3fbd7 to
ad6556e
Compare
jmarrec
commented
Sep 4, 2024
| @@ -524,6 +524,7 @@ set(QT_INSTALL_DIR "" CACHE PATH "Path to Qt Install") | |||
| set(QT_VERSION "6.5.2" CACHE STRING "Qt target version, defaults to 6.5.2") | |||
|
|
|||
| # For AboutBox, but also validates that the version is valid | |||
| string(TIMESTAMP CURRENT_YEAR "%Y") | |||
There was a problem hiding this comment.
Get current year by cmake
| <h2>ModelEditor</h2> \ | ||
| <p>Version: ${OPENSTUDIOAPPLICATION_LONG_VERSION}</p> \ | ||
| <p>Compiler: ${ABOUT_COMPILER}</p> \ | ||
| <p>openstudio SDK (core) version: ${openstudio_VERSION}</p> \ | ||
| <p>Copyright © 2008-2019, Alliance for Sustainable Energy, LLC, and other contributors. All rights reserved.</p> \ | ||
| <p>Copyright © 2020-${CURRENT_YEAR}, OpenStudio Coalition and other contributors. All rights reserved.</p> \ |
There was a problem hiding this comment.
Use that in AboutBox
| @@ -5,10 +5,10 @@ | |||
| <p>Version: ${OPENSTUDIOAPPLICATION_LONG_VERSION}</p> \ | |||
| <p>Compiler: ${ABOUT_COMPILER}</p> \ | |||
| <p><a href='https://openstudio.net'>OpenStudio SDK (core)</a> version: ${openstudio_VERSION}</p> \ | |||
| <p>Copyright © 2020-2023, OpenStudio Coalition and other contributors. All rights reserved.</p> \ | |||
| <p>Copyright © 2020-${CURRENT_YEAR}, OpenStudio Coalition and other contributors. All rights reserved.</p> \ | |||
| <p>OpenStudio is a cross-platform tool to support whole building energy and daylight modeling using <a href='http://apps1.eere.energy.gov/buildings/energyplus/'>EnergyPlus</a> and <a href='http://www.radiance-online.org/'>Radiance</a>.</p> \ | ||
| <p>OpenStudio uses the following QT modules (version ${QT_VERSION}) that are dynamically linked using GNU Lesser General Public License (LGPL): \ | ||
| <font size='2'>Qt6Core, Qt6Core5Compat Qt6Widgets, Qt6Network, Qt6Concurrent, Qt6PrintSupport, Qt6Gui, Qt6Quick, Qt6QuickWidgets, Qt6Qml, Qt6QmlModels, Qt6WebChannel, Qt6Positioning, Qt6WebEngine, Qt6WebEngineWidgets, QtWebEngineCore, Qt6DBus, Qt6Xml, Qt6Svg, Qt6OpenGL</font> </p> \ | ||
| <font size='2'>Qt6Core, Qt6Core5Compat Qt6Widgets, Qt6Network, Qt6Concurrent, Qt6PrintSupport, Qt6Gui, Qt6Quick, Qt6QuickWidgets, Qt6Qml, Qt6QmlModels, Qt6WebChannel, Qt6Positioning, Qt6WebEngine, Qt6WebEngineWidgets, QtWebEngineCore, Qt6DBus, Qt6Xml, Qt6Svg, Qt6Charts, Qt6OpenGL, Qt6OpenGLWidgets</font> </p> \ |
There was a problem hiding this comment.
And add the new Qt deps here
Comment on lines
+2
to
+3
| * OpenStudio(R), Copyright (c) OpenStudio Coalition and other contributors. | ||
| * See also https://openstudiocoalition.org/about/software_license/ |
There was a problem hiding this comment.
For what it's worth, that webpage points in turn to the root of the repo's LICENSE.md
https://openstudiocoalition.org/about/software_license/
Visit the BSD3 license web page for details on the terms of use.
Comment on lines
+2
to
+3
| # OpenStudio(R), Copyright (c) OpenStudio Coalition and other contributors. | ||
| # See also https://openstudiocoalition.org/about/software_license/ |
There was a problem hiding this comment.
Ruby example change
jmarrec
commented
Sep 4, 2024
| @@ -1,4 +1,4 @@ | |||
| OpenStudio(R), Copyright (c) 2020-2023, OpenStudio Coalition and other contributors. All rights reserved. | |||
| OpenStudio(R), Copyright (c) 2020-2024, OpenStudio Coalition and other contributors. All rights reserved. | |||
There was a problem hiding this comment.
Update the root LICENSE.md. This is the ONLY file we need to keep up to date now! 🎊
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the kind of PRs I like: