Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary remove dulcy from rotation #920

Closed
mtmail opened this issue Aug 4, 2023 · 5 comments
Closed

Temporary remove dulcy from rotation #920

mtmail opened this issue Aug 4, 2023 · 5 comments

Comments

@mtmail
Copy link

mtmail commented Aug 4, 2023

dulcy serves a pre-release of Nominatim version 5 (python rewrite). It introduced changes that cause issues for users of the service. See osm-search/Nominatim#3134 (comment)

Sarah is on leave at the moment. Grant suggested in openstreetmap/openstreetmap-website#4137 that the server can be removed if needed.

Unless there’s other communication with Sarah I‘d like to ask to remove it temporarily, it seems to break too many user‘s websites.

@tomhughes
Copy link
Member

Do you have any evidence to support your claim?

Most of the reports I've seen are for sites that are sending queries that are at least arguably bogus. I have no evidence of widespread major breakage significant enough to warrant taking the machine our of service and I'd rather continue to gather details of problems so that they can be fixed if necessary.

@gravitystorm
Copy link
Collaborator

Do you have any evidence to support your claim?

Wow, that's not a helpful response!

@mtmail linked to two different places that describe the problems people are having with the version of nominatim running on dulcy - first, an issue with many comments from users of nominatim, and secondly, an issue showing breakage on openstreetmap.org itself! It's hard to understand how that's not evidence of a problem.

osm-search/Nominatim#3138 is the main thing here for me - the response format has (inadvertently?) changed, @mtmail caught it causing a problem for osm.org, and so I think it's reasonable to suggest something needs to be done.

Now maybe I'm misunderstanding what's going on, and maybe @mtmail is too, and maybe you've already taken steps to avoid this from impacting the osm.org frontpage - but in that case, it would be nice to told what we're misunderstanding, rather than getting a curt brush-off.

@tomhughes
Copy link
Member

tomhughes commented Aug 4, 2023

Well the first one of those is a classic example of the kind of thing I'm talking about, where it's specific to clients that are doing something a bit odd in adding a trailing slash to the endpoint.

The second one is probably the only thing I'm aware of that might lead me to disable it. I did consider adding a workaround to the rails code this morning but decided I couldn't really make a case for it at least until we get a decision from Nominatim about what the correct response format is. Equally I decided that given that server only takes a relatively small proportion of requests and we're only talking about a couple of days that it wasn't worth disabling it for that.

@tomhughes
Copy link
Member

I've dropped dulcy from DNS for now.

@gravitystorm
Copy link
Collaborator

Thanks Tom 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants