Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place search is broken #9822

Closed
tordans opened this issue Aug 8, 2023 · 5 comments
Closed

Place search is broken #9822

tordans opened this issue Aug 8, 2023 · 5 comments
Labels
bug A bug - let's fix this!

Comments

@tordans
Copy link
Collaborator

tordans commented Aug 8, 2023

URL

No response

How to reproduce the issue?

It looks like the same issue Ben describes in facebook/Rapid#1007 applies to iD as well. I get a CORS error when searching for Huston.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

@nickrsan
Copy link
Collaborator

nickrsan commented Aug 8, 2023

Confirming that I also get a 404 for the request to https://nominatim.openstreetmap.org/search/ and that only POIs/data loaded in the current view display in search, in agreement with what Ben noted.

@nickrsan nickrsan added the bug A bug - let's fix this! label Aug 8, 2023
@k-yle
Copy link
Collaborator

k-yle commented Aug 8, 2023

This is caused by osm-search/Nominatim#3134, although I thought openstreetmap/operations#920 would have temporarily fixed the issue...

@tordans
Copy link
Collaborator Author

tordans commented Aug 9, 2023

@k-yle I still get the CORS error. Is this maybe something different from the other "search/" issues?

@tordans
Copy link
Collaborator Author

tordans commented Aug 10, 2023

I see this was fixed by @tyrasd last week via a454aa3 and a460013.
I can confirm it works on https://ideditor.netlify.app/

@tyrasd since the change referenced in #9822 (comment) does not solve the issue on production, maybe this is something for a hotfix release?

I will close the issue now, since it is handled pending deployment…

@tordans tordans closed this as completed Aug 10, 2023
@tyrasd
Copy link
Member

tyrasd commented Aug 16, 2023

@tordans yeah, I thought so as well, but as I had planned to do a full release soon anyway, it is now included in v2.27.0, which should be deployed soon. ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

4 participants