Deprecate non-BCP-47 language tags for name keys
#1356
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
Bug: openstreetmap#1356 Change-Id: Ib079be59b77870f0519a97a5d9365932f57e73a2
- `alt_name` - `loc_name` - `name` - `nat_name` - `official_name` - `reg_name` - `short_name` Bug: openstreetmap#1356 Change-Id: Ib079be59b77870f0519a97a5d9365932f57e73a2
| { | ||
| "old": {"name:nan-TL": "*"}, | ||
| "replace": {"name:nan-Latn-tailo": "$1"} | ||
| }, |
There was a problem hiding this comment.
Some of these deprecations replace very common keys with much less common keys. For example, name:nan-TL=* still has some 38,000 occurrences while name:nan-Latn-tailo=* has only eight. I realize that’s part of the motivation for this change, and conforming to the standard is good for interoperability, but have you given a heads-up to the relevant communities yet? Not everyone uses id-tagging-schema–powered editors, and some data consumers may need to update their special cases for nonconformant codes. Given the number of languages involved, consider posting something to the global forum and then reaching out to individual local or language communities separately (such as the Asia Telegram chat).
There was a problem hiding this comment.
This had been already discussed in both OpenStreetMap Mainland China and OpenStreetMap Taiwan Telegram groups.
There was a problem hiding this comment.
Thanks for these links. I can’t read Chinese, but assuming the changes were uncontroversial, the next step would be to alert the broader community. Many software developers don’t participate in the Chinese-language communication channels. Off the top of my head, here are some data consumers that will be affected by the deprecation of name:zh_pinyin=* in favor of name:zh-Latn-pinyin=* or the deprecation of name:zh-CN=*, name:zh-HK=*, and name:zh-TW=* in favor of name:zh-Hans-CN=*, name:zh-Hant-HK=*, and name:zh-Hant-TW=*, respectively:
- OsmAnd
- Organic Maps
- OSMUS Tile Service (used by OSM Americana, OpenTrailMap, etc.)
Additionally, some closed-source products such as Mapbox Streets might be affected, but I don’t have any specific information about that.
Please consider starting a conversation somewhere more visible, such as the tagging forum category, and opening issues against the relevant repositories. We don’t have to wait to merge these changes until the data consumers are fully updated, but we should start the discussion ahead of time, as a courtesy. Thanks for your attention to detail!
There was a problem hiding this comment.
I've asked other community members to handle something about the tagging forum category, waiting for their reply.
We're also checking which repositories are relevant to this change.
There was a problem hiding this comment.
(2024-10-09 17:55 (UTC) Note: https://github.com/osmlab/name-suggestion-index had been identified.)
There was a problem hiding this comment.
- `alt_name` - `loc_name` - `name` - `nat_name` - `official_name` - `reg_name` - `short_name` Bug: openstreetmap#1356 Change-Id: Ib079be59b77870f0519a97a5d9365932f57e73a2
Bug: #1356
Bug: openstreetmap/iD#10488
Change-Id: Ib079be59b77870f0519a97a5d9365932f57e73a2
Description, Motivation & Context
We should stop using non-standard BCP 47 language tags.
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.