Indicate applied and partially applied relations for multi-selection#11949
Draft
aditya1010-max wants to merge 1 commit intoopenstreetmap:developfrom
Draft
Indicate applied and partially applied relations for multi-selection#11949aditya1010-max wants to merge 1 commit intoopenstreetmap:developfrom
aditya1010-max wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
Collaborator
|
@aditya1010-max before look into this…
UI: |
tordans
reviewed
Mar 2, 2026
Comment on lines
+355
to
+368
| var count = relationCounts.get(entity.id) || 0; | ||
| var flags = { | ||
| isCommon: count === selectedEntities.length, | ||
| isPartial: count > 0 && count < selectedEntities.length | ||
| }; | ||
|
|
||
|
|
||
| result.push({ | ||
| relation: entity, | ||
| value, | ||
| display: baseDisplayLabel(entity) | ||
| display: baseDisplayLabel(entity, flags), | ||
| title: value, | ||
| isCommon: flags.isCommon, | ||
| isPartial: flags.isPartial |
Collaborator
There was a problem hiding this comment.
Dont quite see the value in having this extracted and then only used once.
Suggested change
| var count = relationCounts.get(entity.id) || 0; | |
| var flags = { | |
| isCommon: count === selectedEntities.length, | |
| isPartial: count > 0 && count < selectedEntities.length | |
| }; | |
| result.push({ | |
| relation: entity, | |
| value, | |
| display: baseDisplayLabel(entity) | |
| display: baseDisplayLabel(entity, flags), | |
| title: value, | |
| isCommon: flags.isCommon, | |
| isPartial: flags.isPartial | |
| const count = relationCounts.get(entity.id) || 0; | |
| result.push({ | |
| relation: entity, | |
| value, | |
| display: baseDisplayLabel(entity, flags), | |
| title: value, | |
| isCommon: count === selectedEntities.length, | |
| isPartial: count > 0 && count < selectedEntities.length |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple entities are selected, the raw membership editor now indicates
whether a relation applies to all selected entities or only a subset.
This PR addresses one aspect of issue #10981