Fix variable shadowing bug in utilCombinedTags sort#11932
Open
JaiswalShivang wants to merge 1 commit intoopenstreetmap:developfrom
Open
Fix variable shadowing bug in utilCombinedTags sort#11932JaiswalShivang wants to merge 1 commit intoopenstreetmap:developfrom
JaiswalShivang wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
Contributor
|
On which use case you have tested this? |
k-yle
reviewed
Feb 28, 2026
Contributor
Author
|
Tested on the preview deployment by selecting multiple road segments The multi-entity tag editor renders correctly — no errors or regressions. The bug itself is a classic JavaScript var x = 10;
(function() { var x = x; console.log(x); })(); // undefined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11931
In [utilCombinedTags()], the sort callback on line 401 does
var key = keyintending to capture the outer loop variable. Due to JavaScript's
varhoisting,this actually creates a new [key] that is
undefined, shadowing the outer one.This means
tagCounts[key + '=' + val]always looks up"undefined=..."whichreturns
undefined, so the frequency comparison is skipped entirely. Tag valuesare sorted alphabetically instead of by frequency when multiple entities are selected.
Changes
varto [let] in thefor...inloop for proper block scopingvar key = key; // capturelineWhy this works
Array.sort()runs synchronously, so the callback executes immediately whilethe loop variable still holds the correct value. With [let], each iteration
gets its own binding — no capture needed.