Skip to content

Skip disconnected_way validation for Golf Walking Paths#11865

Open
Kayd-06 wants to merge 1 commit intoopenstreetmap:developfrom
Kayd-06:fix/golf-walking-path-validation
Open

Skip disconnected_way validation for Golf Walking Paths#11865
Kayd-06 wants to merge 1 commit intoopenstreetmap:developfrom
Kayd-06:fix/golf-walking-path-validation

Conversation

@Kayd-06
Copy link
Contributor

@Kayd-06 Kayd-06 commented Feb 12, 2026

Golf walking paths (highway=path + golf=path + foot=designated) are often intentionally isolated and should not trigger the disconnected_way validation warning.

I've updated the logic in [modules/validations/disconnected_way.js] and added a new test case in test/spec/validations/disconnected_way.js to verify the fix.

Fixes #11863

Copy link
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test your PR?

@Kayd-06
Copy link
Contributor Author

Kayd-06 commented Feb 13, 2026

Yes, I have verified the fix in two ways:

  1. Automated Tests: I added a new test case to test/spec/validations/disconnected_way.js
    specifically for the isolated golf path tags. I ran the full validation suite via vitest, and all 5 tests passed.

  2. Manual Verification: I ran the editor locally and confirmed that:

  • A way with highway=path + golf=path + foot=designated no longer triggers the "disconnected way" warning.
  • Regular paths still correctly trigger the warning when disconnected.

@k-yle
Copy link
Collaborator

k-yle commented Feb 16, 2026

what made you choose that specific tag combination? it's different to the tags used by the preset, so it won't fix the example mentioned in #11863

@Kayd-06 Kayd-06 force-pushed the fix/golf-walking-path-validation branch from c20137f to 9c76d6b Compare February 16, 2026 18:50
Golf walking paths (golf=path) and cartpaths (golf=cartpath) are often intentionally isolated and should not trigger the disconnected_way validation warning.

Fixes openstreetmap#11863
@Kayd-06
Copy link
Contributor Author

Kayd-06 commented Feb 16, 2026

I've updated the validation to match the actual iD preset tagging and added tests covering:

  • Golf walking path preset
  • Golf cartpath preset
  • The original reporter tag combination

Please let me know if anything else should be adjusted.

@matkoniecz
Copy link
Contributor

can you answer

what made you choose that specific tag combination?

? How you ended with those tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation - Golf Walking Path should not have to be connected to another path

3 participants