Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu 24.04 support #659

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Firefishy
Copy link
Member

@Firefishy Firefishy commented Apr 22, 2024

Pull Request with tests to get us ready for the upcoming release of Ubuntu 24.04 (Noble Numbat)

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch 2 times, most recently from 4ad3ab9 to 4a8c172 Compare April 22, 2024 13:00
cookbooks/apt/recipes/default.rb Outdated Show resolved Hide resolved
@Firefishy Firefishy requested a review from tomhughes April 22, 2024 15:55
Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as far as it goes - there is one test failure in the devices cookbook when it tries to run update-initramfs which seems to be missing. Has 24.04 switched to dracut or something?

@Firefishy Firefishy marked this pull request as ready for review April 22, 2024 17:12
@tomhughes
Copy link
Member

Oh the initramfs thing wasn't anything to do with 24.04 because this PR isn't actually enabling 24.04 tests in actions?

@Firefishy
Copy link
Member Author

Ran tests against 24.04 now.

@Firefishy
Copy link
Member Author

Firefishy commented Apr 23, 2024

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch 3 times, most recently from e5c4c23 to ad2a5ba Compare May 11, 2024 00:30
@Firefishy
Copy link
Member Author

Still waiting for fixed fail2ban

@tomhughes tomhughes force-pushed the master branch 2 times, most recently from b1b5d07 to 1817631 Compare June 16, 2024 15:30
@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch from ad2a5ba to 2a5eba2 Compare June 27, 2024 03:39
@Firefishy
Copy link
Member Author

Down to only a few tests still failing.

@Firefishy
Copy link
Member Author

@pnorman ^^^

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch 2 times, most recently from 0b828fd to a08b436 Compare July 29, 2024 16:57
@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 29, 2024

At least for CGImap you could take the existing jammy package and copy/rebuild it on noble. When I tried this, unit tests were passing OK. Package naming is a bit off though, as it still refers to jammy.

Here’s an older test run (=not the latest 0.9.3 release) : https://launchpad.net/~mmd-osm/+archive/ubuntu/cgimap-902-noble/+packages

This is mainly intended for testing purposes. Creating proper packages for noble shouldn’t be a big deal.

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch 2 times, most recently from 20382d0 to a4d38eb Compare August 6, 2024 22:29
@Firefishy
Copy link
Member Author

Rebased again latest changes from master

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch from d6f33d5 to b5b0a98 Compare August 7, 2024 16:13
Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "linting style fixes" commit should just be squashed into the previous commit that it is testing and the "fix mail test" commit can be squashed into the other spamassassin commit.

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch from 1f6f362 to 0836b4c Compare August 28, 2024 15:45
@Firefishy
Copy link
Member Author

The "linting style fixes" commit should just be squashed into the previous commit that it is testing and the "fix mail test" commit can be squashed into the other spamassassin commit.

Done.

@Firefishy
Copy link
Member Author

I've removed the Ubuntu 24.04 libv8-node gem workaround as it is no longer needed.

@Firefishy Firefishy force-pushed the add-ubuntu-2404-to-tests branch 2 times, most recently from 8de0c5a to 2591006 Compare October 8, 2024 10:35
@tomhughes tomhughes force-pushed the master branch 2 times, most recently from aa9703b to 07840ce Compare November 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants