Add Translate extension to Wiki #568
Conversation
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
3b728d8 to
4ae2339
Compare
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
3cc04b0 to
82f971c
Compare
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
749a519 to
b7e5b92
Compare
|
Could someone please review this? It has been over a year since the proposal passed to add this. |
|
Can you tell me what functionality this introduces? |
|
@Firefishy Please see the proposal for an in-depth description about what functionality it offers. |
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
0305831 to
e3574f3
Compare
|
So... update? |
|
Will you be around when this causes the wiki to break or block upgrades? This is a fairly deep plugin. I am not comfortable supporting it on my own. |
|
I will be. Honestly I have not tested this PR with the current Wiki stack since I don't have chef setup or anything and don't really know how to set it up. I guess creating that docker container for the wiki which has been something I've wanted to do we might think of doing before this as well to test it (openstreetmap/operations#873). |
|
If we install it and then have to remove it in a couple months, what are the consequences? What's the uninstall procedure? |
|
@pnorman All the pages created as "translated" pages will just be kept in normal page form. For example, Key:Highway and its Spanish translation produced by the Translate extension at Key:Highway/es will become normal pages at Key:Highway and Key:Highway/es. We will need to add the {{Languages}} template to those pages but that should be pretty easy to automate. |
tomhughes
force-pushed
the
master
branch
3 times, most recently
from
d3175b1 to
a07b42e
Compare
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
74f83a1 to
73471b4
Compare
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
013d3ba to
c295927
Compare
| $wgTranslateTranslationServices['TTMServer'] = array( | ||
| 'type' => 'ttmserver', | ||
| 'class' => 'ElasticSearchTTMServer', | ||
| 'cutoff' => 0.75, | ||
| /* | ||
| * See http://elastica.io/getting-started/installation.html | ||
| * See https://github.com/ruflin/Elastica/blob/8.x/src/Client.php | ||
| */ | ||
| 'config' => [ 'servers' => [ 'host' => '127.0.0.1', 'port' => 9114 ] ] | ||
| ); |
There was a problem hiding this comment.
| $wgTranslateTranslationServices['TTMServer'] = array( | |
| 'type' => 'ttmserver', | |
| 'class' => 'ElasticSearchTTMServer', | |
| 'cutoff' => 0.75, | |
| /* | |
| * See http://elastica.io/getting-started/installation.html | |
| * See https://github.com/ruflin/Elastica/blob/8.x/src/Client.php | |
| */ | |
| 'config' => [ 'servers' => [ 'host' => '127.0.0.1', 'port' => 9114 ] ] | |
| ); | |
| $wgTranslateTranslationServices['TTMServer'] = [ | |
| 'type' => 'ttmserver', | |
| 'class' => 'ElasticSearchTTMServer', | |
| 'cutoff' => 0.75, | |
| /* | |
| * See http://elastica.io/getting-started/installation.html | |
| * See https://github.com/ruflin/Elastica/blob/8.x/src/Client.php | |
| */ | |
| 'config' => [ 'servers' => [ 'host' => '127.0.0.1', 'port' => 9114 ] ] | |
| ]; |
The mix use of old syntax and new syntax has slightly confused me :)
|
|
||
| wfLoadExtension( 'Translate' ); | ||
| $wgGroupPermissions['user']['translate'] = true; | ||
| $wgGroupPermissions['user']['skipcaptcha'] = true; // Bug 34182: needed with ConfirmEdit |
There was a problem hiding this comment.
Bugzilla 34182 is https://phabricator.wikimedia.org/T36182
There was a problem hiding this comment.
Though the bug, I am not sure if it is good to disable the captcha for all logged-in users.
In another perspective, does OSM wiki have ConfirmEdit enabled? (Is this line needed?)
Anyway, I think it would be good if 'autoconfirmed' is used than 'user'.
| /** | ||
| * Add a preference "Do not send me email newsletters" in the email preferences. | ||
| */ | ||
| $wgTranslateNewsletterPreference = true; | ||
|
|
There was a problem hiding this comment.
| /** | |
| * Add a preference "Do not send me email newsletters" in the email preferences. | |
| */ | |
| $wgTranslateNewsletterPreference = true; |
This configuration variable removed in 2020. (MediaWiki 1.35)
wikimedia/mediawiki-extensions-Translate@1c43244
Bug: T134633
@lectrician1 If you can, could you please take the time to test it with Chef?
@Nikerabbit I am sorry to mention you suddenly. Do you know what will happen if Translate extension is uninstalled? Are there any cases of this happened on any wiki? |
|
Not to my knowledge. Main changes would be tags would displaying verbatim and all translations would become editable as normal pages. |
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
b1b5d07 to
1817631
Compare
|
@lens0021 I do not have a local dev environment for the chef configuration. Is it that hard to setup? The configuration looks very osm-server specific. Could someone else possibly test the configuration who has a running chef environment? |
tomhughes
force-pushed
the
master
branch
2 times, most recently
from
aa9703b to
07840ce
Compare
This adds the Translate extension to the Wiki.
All other extension dependencies have already been installed so no other extensions are added as part of this request.
User rights and the new role of "translateadmin" have been configured according to the original proposal.
The OSM ElasticSearch server will now be utilized for storing translation memories.
Closes openstreetmap/operations#649