Skip to content

refactor sheerid webhook code, do not trigger on confirmed #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor sheerid webhook code, do not trigger on confirmed #1300

wants to merge 1 commit into from

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Mar 19, 2025

Major change is to prevent sheerid from overriding a confirmed status.

Took the liberty to try and refactor some of this code while here to make it more readable, handle error better, and increase test coverage.

@mwvolo mwvolo requested a review from Dantemss March 19, 2025 22:56
Dantemss
Dantemss reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So handle_user_verification will now ignore subsequent (duplicate?) hooks, but update_user_with_verification_data and process_verification_step still change the user info and faculty status. Is that expected?

@mwvolo mwvolo marked this pull request as draft April 14, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dantemss Dantemss Dantemss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwvolo @Dantemss