build: Manage Dockerfile with Dofigen #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taorepoara is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
| # Temp solution for bun | ||
| RUN bun install --ignore-scripts | ||
| # install | ||
| FROM oven/bun@sha256:eb409bed239c3adff079a6b71283f151e802d66b99f643ba7a71e1be7d3da513 AS install |
There was a problem hiding this comment.
@taorepoara do we really need the hash?
There was a problem hiding this comment.
The hash gives you the control on the FROM images. Dofigen does it by default, but I'll add a flag to avoid that: lenra-io/dofigen#278
| workdir: /app/ | ||
| # Copy project | ||
| bind: | ||
| - package.json |
There was a problem hiding this comment.
I m ashamed by that part our monorepo is 😱
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@thibaultleouay Let me know if there is things to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Generate the server Dockerfile with Dofigen in order to optimize the resulting image size and the build time.
A picture tells a thousand words (if any)
Before this PR
{Please add a screenshot here}
After this PR
{Please add a screenshot here}
Related Issue (optional)
#1012