Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log at ERROR level for SeverityError Conditions #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csibbitt
Copy link
Contributor

@csibbitt csibbitt commented Nov 1, 2024

I found several cases where a reconcile error occurs, but the log message doesn't stand out because it was at INFO level. Most cases in this code use log.Error when the resource status is being marked unready w/ condition.SeverityError, so this makes it consistent.

Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csibbitt
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c4f3726726fc4585af000ee5663f3061

openstack-k8s-operators-content-provider FAILURE in 7m 09s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ telemetry-operator-multinode-autoscaling-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ telemetry-operator-multinode-default-telemetry SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ telemetry-operator-multinode-logging SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-tests-on-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

@csibbitt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 0afa95b link true /test precommit-check
ci/prow/telemetry-operator-build-deploy 0afa95b link false /test telemetry-operator-build-deploy
ci/prow/telemetry-operator-build-deploy-kuttl 0afa95b link true /test telemetry-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant