Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Make]Run kubefwd when operator runs outside of OCP #608

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Nov 28, 2023

No description provided.

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer
Copy link
Contributor Author

gibizer commented Nov 28, 2023

2023-11-28T11:26:28.399+0100	ERROR	Failed cleaning services from nova db	{"controller": "novascheduler", "controllerGroup": "nova.openstack.org", "controllerKind": "NovaScheduler", "NovaScheduler": {"name":"nova-scheduler","namespace":"openstack"}, "namespace": "openstack", "name": "nova-scheduler", "reconcileID": "7de45ff9-c5b4-4d81-8a4c-06c140f41933", "error": "Get \"https://nova-public-openstack.apps-crc.testing/v2.1/os-services?binary=nova-scheduler\": x509: certificate signed by unknown authority"}

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for my own usage i would continue to use
the routing approach from
https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/docs/contributing/development_environment.md#route-networks
since if i run locally its almost exclusively via vscode

although i do use this target to inially configure the webhooks so i don't exclusively use vscode

#!/bin/bash
set -ex

pushd bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason you choose to do it this way instead of using a make target like we have for operator-lint or the SDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no specific reason, it is started as a hack :)

@mrkisaolamb
Copy link
Contributor

2023-11-28T11:26:28.399+0100	ERROR	Failed cleaning services from nova db	{"controller": "novascheduler", "controllerGroup": "nova.openstack.org", "controllerKind": "NovaScheduler", "NovaScheduler": {"name":"nova-scheduler","namespace":"openstack"}, "namespace": "openstack", "name": "nova-scheduler", "reconcileID": "7de45ff9-c5b4-4d81-8a4c-06c140f41933", "error": "Get \"https://nova-public-openstack.apps-crc.testing/v2.1/os-services?binary=nova-scheduler\": x509: certificate signed by unknown authority"}

This should be fixed with this patch: #611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants