don't assume any CSVs are installed

[zzzeek]

change ae93738 added the assumption that a CSV would be installed under
operators.coreos.com/openstack-operator.openstack-operators, but this cannot be assumed. I run run-with-webhook with no csvs installed at all, so this check as well must only proceed with patch commands if CSV_NAME isn't blank.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zzzeek
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zzzeek]

just to clarify, the patch at ae93738 produces this output for me

++ oc get csv -n openstack-operators -l operators.coreos.com/mariadb-operator.openstack-operators -o name
+ CSV_NAME=
+ '[' -n '' ']'
++ oc get csv -n openstack-operators -l operators.coreos.com/openstack-operator.openstack-operators -o name
+ CSV_NAME=
+ printf '\n\tNow patching openstack operator CSV to scale down deployment resource.
    To restore it, use:
    oc patch  -n openstack-operators --type=json -p="[{'\''op'\'': '\''replace'\'', '\''path'\'': '\''/spec/install/spec/deployments/0/spec/replicas'\'', '\''value'\'': 1}]"'

        Now patching openstack operator CSV to scale down deployment resource.
    To restore it, use:
    oc patch  -n openstack-operators --type=json -p="[{'op': 'replace', 'path': '/spec/install/spec/deployments/0/spec/replicas', 'value': 1}]"+ oc patch '' -n openstack-operators --type=json '-p=[{'\''op'\'': '\''replace'\'', '\''path'\'': '\''/spec/install/spec/deployments/0/spec/replicas'\'', '\''value'\'': 0}]'
error: the server doesn't have a resource type ""
make: *** [Makefile:380: run-with-webhook] Error 1

[zzzeek]

/retest-required

[karelyatin]

/lgtm
Thanks Michael, i had missed this case

[zzzeek]

/retest-required

[openshift-ci]

@zzzeek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/mariadb-operator-build-deploy-chainsaw	69ee969	link	true	/test mariadb-operator-build-deploy-chainsaw
ci/prow/mariadb-operator-build-deploy-kuttl	69ee969	link	true	/test mariadb-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.