Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert runlogwatch.sh to use inotifywait #484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steveb
Copy link
Collaborator

@steveb steveb commented Oct 15, 2024

This aligns with metal3 runlogwatch.sh[1] which is possible now that inotify-tools package is available[2].

[1] https://github.com/metal3-io/ironic-image/pull/548/files
[2] openstack-k8s-operators/tcib@0795bb9

Jira: OSPRH-10240

@openshift-ci openshift-ci bot requested review from abays and stuggi October 15, 2024 23:17
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@steveb
Copy link
Collaborator Author

steveb commented Oct 16, 2024

This has been moved to FR3, hold until FR1 is branched

@steveb
Copy link
Collaborator Author

steveb commented Oct 22, 2024

This can be reviewed now, fr1 has been branched

@steveb
Copy link
Collaborator Author

steveb commented Oct 22, 2024

/retest

2 similar comments
@steveb
Copy link
Collaborator Author

steveb commented Oct 28, 2024

/retest

@steveb
Copy link
Collaborator Author

steveb commented Oct 31, 2024

/retest

@steveb
Copy link
Collaborator Author

steveb commented Nov 3, 2024

Ironic images have been promoted
/retest

@steveb
Copy link
Collaborator Author

steveb commented Nov 5, 2024

/retest

This aligns with metal3 runlogwatch.sh[1] which is possible now that
inotify-tools package is available[2].

[1] https://github.com/metal3-io/ironic-image/pull/548/files
[2] openstack-k8s-operators/tcib@0795bb9

Jira: OSPRH-10240
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

@steveb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ironic-operator-build-deploy-kuttl 3c4aeab link true /test ironic-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant