Refactor deployment.go code

[bshephar]

This change does some refactoring of the deployment.go code to avoid overuse of string literals and replace with consts. Along with moving excessive code from the main Deployment function into dedicated functions that are easier to test and read.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bshephar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bshephar]

/test horizon-operator-build-deploy-kuttl

[openshift-ci]

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/horizon-operator-build-deploy-kuttl	fe0fd28	link	true	/test horizon-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bshephar]

Seems to be an issue with the VolumeMounts:

    case.go:380: resource Horizon:horizon-kuttl-tests/horizon: .status.readyCount: key is missing from map
    logger.go:42: 12:27:14 | tls-deployment | skipping kubernetes event logging

Failure is related to the missing combined-ca-bundle mount:

❯ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_horizon-operator/365/pull-ci-openstack-k8s-operators-horizon-operator-main-horizon-operator-build-deploy-kuttl/1876224488794755072/artifacts/horizon-operator-build-deploy-kuttl/openstack-k8s-operators-gather/artifacts/must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-b14292f8b5bb013eb06a54a9a50a2d892f6dd255901a7842f65567beb8cd090d/namespaces/horizon-kuttl-tests/crs/horizons.horizon.openstack.org/horizon.yaml" | yq '.status.conditions[0]'
lastTransitionTime: "2025-01-06T12:27:14Z"
message: 'TLSInput is missing: combined-ca-bundle'
reason: Requested
severity: Info
status: "False"
type: Ready