Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specified base64 encoded password #841

Conversation

klgill
Copy link
Contributor

@klgill klgill commented Mar 10, 2025

https://issues.redhat.com/browse/OSPRH-14567

I also fixed an unrelated formatting issue that I saw in the preview.

This change can be published async, but I think we still need to backport it to the fr2 branch.

@klgill klgill requested a review from jistr March 10, 2025 15:41
@jistr
Copy link
Contributor

jistr commented Mar 12, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jistr
Copy link
Contributor

jistr commented Mar 12, 2025

/cherry-pick 18.0-fr2

@openshift-cherrypick-robot

@jistr: once the present PR merges, I will cherry-pick it on top of 18.0-fr2 in a new PR and assign it to you.

In response to this:

/cherry-pick 18.0-fr2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ea456a3 into openstack-k8s-operators:main Mar 12, 2025
6 checks passed
@openshift-cherrypick-robot

@jistr: new pull request created: #843

In response to this:

/cherry-pick 18.0-fr2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants