Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cinder netapp nfs backend adoption #768

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

support cinder netapp nfs backend adoption #768

wants to merge 2 commits into from
+59 −1

Conversation

katarimanojk
Copy link
Contributor

Add support cinder netapp nfs backend adoption

@katarimanojk katarimanojk self-assigned this Dec 17, 2024
@katarimanojk katarimanojk marked this pull request as draft December 17, 2024 15:38
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a067ad53012a42dc92d88fc994c777d9

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 12m 15s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 2h 57m 26s

@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch 2 times, most recently from 6e54476 to 2bb7ac4 Compare December 18, 2024 11:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/791ca427139f48fa816f7e8dbbf370e7

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 59m 28s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 03m 13s

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 3, 2025
@katarimanojk katarimanojk removed the Stale label Jan 8, 2025
@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch from 349c60d to 36422f5 Compare January 22, 2025 08:23
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign archana203 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch from 36422f5 to 13135c6 Compare January 22, 2025 08:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/39873e8556b7429697f742dee7ccd10a

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 56m 51s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 14m 00s

@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch from 13135c6 to 83f2164 Compare February 3, 2025 06:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a08af4c12f842a5993e5366616c90e6

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 52m 58s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 56m 13s

tosky
tosky requested changes Feb 13, 2025
View reviewed changes
tests/roles/cinder_adoption/files/cinder-volume-ontap-secrets.yaml
name: cinder-volume-ontap-secrets
type: Opaque
stringData:
ontap-cinder-secrets: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of defining the secret here, it may make sense to extract the required information from the OSP deployment. Barbican did this for example:

data-plane-adoption/tests/roles/barbican_adoption/tasks/main.yaml

Line 6 in ef823f2

oc set data secret/osp-secret "BarbicanSimpleCryptoKEK=$($CONTROLLER1_SSH "sudo python3 -c \"import configparser; c = configparser.ConfigParser(); c.read('/var/lib/config-data/puppet-generated/barbican/etc/barbican/barbican.conf'); print(c['simple_crypto_plugin']['kek'])\"")"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tosky yeah, i think it can be extracted from OSP deployment , first we need to look at how the secrets section is populated in /var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf.

tests/roles/cinder_adoption/tasks/volume_backend.yaml Outdated
when: cinder_volume_backend == 'ceph'
ansible.builtin.shell: |
{{ shell_header }}
{{ oc_header }}
oc patch openstackcontrolplane openstack --type=merge --patch '{{ cinder_volume_backend_patch }}'

- name: deploy podified Cinder volume with netapp NFS
when: cinder_volume_backend == 'ontap'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ontap or ontap-nfs ? ontap could provide other protocols too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, changed it as ontap-nfs.

@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch from 8cea41f to 3a8c071 Compare February 17, 2025 09:28
@katarimanojk
support cinder netapp nfs backend adoption
8094bbc 
Add support cinder netapp nfs backend adoption
@katarimanojk
testing purpose
71df8bb
@katarimanojk katarimanojk force-pushed the adoption_support_for_cinder_nfs-protocol branch from 3a8c071 to 71df8bb Compare February 19, 2025 16:13
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e9eb1cfeb49437e94d68602fdeedb36

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph POST_FAILURE in 3h 16m 34s
❌ adoption-standalone-to-crc-no-ceph POST_FAILURE in 3h 14m 49s

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 7, 2025
@katarimanojk katarimanojk removed the Stale label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosky tosky tosky requested changes

Assignees

@katarimanojk katarimanojk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katarimanojk @tosky