[test-operator] Improve variables overwriting #3446
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sdatko
force-pushed
the
test-operator-output
branch
from
8f8fc0b to
92243f7
Compare
sdatko
changed the title
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8319138fa8b541b591035f86851ddb43 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 49s |
As part of processing test-operator stages, there is a task that takes all defined Ansible variables and overrides them with matching stage-specific variables. However, this task focuses in the end only on variables specific to test-operator. Yet, because the filtering is done on Ansible task-level, we end up with 80% of the `ansible-post-deployment.log` filled with entries like `skipping <variable_name>`. To make this worse, it exposes some deployment-time secrets as a side-effect. This commit moves the filtering from task-level to earlier phase ~ when the loop arguments are prepared, so we will do override only on the test-operator-related variables, reducing the useless output and avoiding secrets exposure.
sdatko
force-pushed
the
test-operator-output
branch
from
92243f7 to
b7b7c63
Compare
2 participants
As part of processing test-operator stages, there is a task that takes all defined Ansible variables and overrides them with matching stage-specific variables. However, this task focuses in the end only on variables specific to test-operator. Yet, because the filtering is done on Ansible task-level, we end up with 80% of the
ansible-post-deployment.logfilled with entries likeskipping <variable_name>. To make this worse, it exposes some deployment-time secrets as a side-effect.This commit moves the filtering from task-level to earlier phase ~ when the loop arguments are prepared, so we will do override only on the test-operator-related variables, reducing the useless output and avoiding secrets exposure.