Skip to content

Move cifmw_architecture_repo var to group_vars #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move cifmw_architecture_repo var to group_vars #3445

wants to merge 1 commit into from
+24 −32

Conversation

@amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Oct 30, 2025

This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework

Depends-On: #3438

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amartyasinha amartyasinha force-pushed the architecture-repo-group-vars branch from 80913fb to 0151319 Compare October 30, 2025 07:05
abays
abays reviewed Oct 30, 2025
View reviewed changes
@amartyasinha amartyasinha force-pushed the architecture-repo-group-vars branch from 0151319 to 7dff01c Compare October 30, 2025 08:40
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Oct 30, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/179225a458454813bc22d6f862784dd1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 51s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 06s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 34s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 27m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 23m 14s
❌ cifmw-pod-pre-commit FAILURE in 6m 32s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 25s
✔️ build-push-container-cifmw-client SUCCESS in 19m 57s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 21s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 26s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 27s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 54s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Oct 30, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Oct 30, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d97c0e7ad2b4e4cac787e0810f8ff68

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 21m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 30s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 21s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 58m 03s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 32s
❌ cifmw-pod-pre-commit FAILURE in 6m 21s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 28s
✔️ build-push-container-cifmw-client SUCCESS in 20m 01s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 18s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 40s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 1m 47s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 47s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Oct 30, 2025

recheck

@amartyasinha amartyasinha mentioned this pull request Oct 31, 2025
Open
@amartyasinha amartyasinha marked this pull request as ready for review November 3, 2025 04:50
@amartyasinha amartyasinha requested review from a team as code owners November 3, 2025 04:50
evallesp
evallesp previously approved these changes Nov 3, 2025
View reviewed changes
@amartyasinha amartyasinha requested a review from abays November 3, 2025 06:30
danpawlik
danpawlik previously approved these changes Nov 3, 2025
View reviewed changes
Valkyrie00
Valkyrie00 previously approved these changes Nov 3, 2025
View reviewed changes
abays
abays previously approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with HCI VA outside of Zuul CI context, and it succeeded.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 3, 2025
fultonj
fultonj reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@amartyasinha amartyasinha requested a review from fultonj November 3, 2025 13:46
@amartyasinha amartyasinha force-pushed the architecture-repo-group-vars branch from 7dff01c to f9a0f5a Compare November 4, 2025 04:04
@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

New changes are detected. LGTM label has been removed.

@amartyasinha amartyasinha force-pushed the architecture-repo-group-vars branch from f9a0f5a to 1efd0dc Compare November 4, 2025 04:20
@amartyasinha
Move cifmw_architecture_repo var to group_vars
73dfac3 
This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework

Signed-off-by: Amartya Sinha <[email protected]>
@amartyasinha amartyasinha force-pushed the architecture-repo-group-vars branch from 1efd0dc to 73dfac3 Compare November 4, 2025 05:51
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 4, 2025

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Nov 4, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 4, 2025

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Nov 4, 2025

recheck

1 similar comment
@danpawlik
Copy link
Contributor

danpawlik commented Nov 5, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/51f77e9482bf4770bf4b6eddf237fe58

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 06s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 24s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 59m 47s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test TIMED_OUT in 30m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 04s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 15s
✔️ build-push-container-cifmw-client SUCCESS in 19m 30s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 32s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 57s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 20s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 51s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments

@danpawlik danpawlik danpawlik left review comments

@Valkyrie00 Valkyrie00 Valkyrie00 left review comments

@evallesp evallesp evallesp left review comments

@fultonj fultonj Awaiting requested review from fultonj

At least 2 approving reviews are required to merge this pull request.

Assignees

@abays abays

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amartyasinha @danpawlik @fultonj @abays @Valkyrie00 @evallesp