Add git minimum length body count validator #3437
Open
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sdatko
reviewed
Oct 28, 2025
danpawlik
force-pushed
the
add-commit-message-verify
branch
from
82f11b5 to
19188fc
Compare
|
let's set as non-voting now. |
danpawlik
changed the title
danpawlik
force-pushed
the
add-commit-message-verify
branch
from
19188fc to
bcf8fe3
Compare
The script is verifying if the minimum body length contains 10 characters. Also raise a warning if there is no: "Signed-Off-By". Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
add-commit-message-verify
branch
from
bcf8fe3 to
6fb1009
Compare
|
PR needs to be merged to get results. |
michburk
reviewed
Nov 5, 2025
|
|
||
| if ! grep -qi '^Signed-off-by:' "$MSG_FILE"; then | ||
| echo -e "\n\n**WARNING: Missing 'Signed-off-by:' line in commit message.**\n" >&2 | ||
| echo "Add: Signed-off-by: Your Name <[email protected]>" >&2 |
There was a problem hiding this comment.
[non-blocking] Maybe we also want to add a tip about including the -s flag when committing to automatically include the Signed-off-by?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script is verifying if the minimum body length contains 10 characters. Also raise a warning if there is no: "Signed-Off-By".
OSPRH-21367