Remove devscript content only when deepscrub is used #3434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We don't need to remove each time the all content necessary to deploy devscript on cleanup. The devscript is using config_$(whoami).sh config file to get necessary information how to deploy the cluster. Let's assume that after executing: "make clean" from dev-scripts [1] project, all the OCP cluster would be removed, and on next execution "make all", the script will be base on config file. [1] https://github.com/openshift-metal3/dev-scripts/ Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
do-not-cleanup-devscript-dir
branch
from
8cca114 to
d95bb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to remove each time the all content necessary to deploy devscript on cleanup. The devscript is using config_$(whoami).sh config file to get necessary information how to deploy the cluster.
Let's assume that after executing: "make clean" from dev-scripts [1] project, all the OCP cluster would be removed, and on next execution "make all", the script will be base on config file.
[1] https://github.com/openshift-metal3/dev-scripts/